Prepare for Moodle 4.3 and PHP 8.2. #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lucaboesch . It looks like there are new errors? Probably due to the merges in MOODLE_401_STABLE. |
lucaboesch
force-pushed
the
MOODLE_403_STABLE
branch
3 times, most recently
from
f2b373d to
e5c0ccb
Compare
|
Checks are passing again, now, @mchurchward. A branch MOODLE_403_STABLE in your repository would be highly appreciated, I think. |
This was referenced Feb 25, 2024
|
@lucaboesch I'm not sure these Behat changes are required. The test pass for me as is. |
lucaboesch
force-pushed
the
MOODLE_403_STABLE
branch
2 times, most recently
from
0334a66 to
12ad081
Compare
|
Yes, you are right, @mchurchward. |
lucaboesch
force-pushed
the
MOODLE_403_STABLE
branch
from
12ad081 to
6fa6d1c
Compare
mchurchward
approved these changes
Mar 28, 2024
|
Hi Luca. Sorry, can you rebase again? |
Closed
|
@lucaboesch I'm not sure what happened, but there are 14 commits in this PR and it doesn't seem like they all belong to this PR. |
lucaboesch
force-pushed
the
MOODLE_403_STABLE
branch
6 times, most recently
from
37fa63d to
cb65739
Compare
|
That should look better now, @mchurchward . |
lucaboesch
force-pushed
the
MOODLE_403_STABLE
branch
from
cb65739 to
c057237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a working branch here that fixes #530.