Skip to content

Conversation

@MaxGhenis
Copy link
Contributor

Summary

Adds a 3x4 table showing federal and state tax breakdown:

Without donation With donation Savings
Federal income tax $X $Y $Z
State income tax $X $Y $Z
Total $X $Y $Z

Changes

  • Add TaxBreakdown schema with federal, state, and total fields
  • Update calculate_donation_metrics to return federal_income_tax and state_income_tax
  • Replace "Detailed breakdown" section with proper table in Results component
  • Total row highlighted with primary color

Test plan

  • Run pytest tests/ - all 33 tests pass
  • Build frontend with npm run build
  • Verify table displays correctly with sample calculation

🤖 Generated with Claude Code

- Add TaxBreakdown schema with federal, state, and total fields
- Update calculate_donation_metrics to return federal and state taxes
- Display 3x4 table showing taxes without/with donation and savings
- Shows breakdown for federal income tax, state income tax, and total

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
givecalc Ready Ready Preview Comment Dec 2, 2025 6:47am

Automatically deploys API to Cloud Run on merge to main.
Requires GCP secrets to be configured in GitHub repository settings:
- GCP_WORKLOAD_IDENTITY_PROVIDER
- GCP_SERVICE_ACCOUNT
- GCP_PROJECT_ID

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- Hardcode states list in frontend (states don't change)
- Remove blocking loading state that waits for /api/states
- UI now renders instantly, only calculate button triggers API call

This improves perceived performance during Cloud Run cold starts.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants