Merge pull request #474 from kilasuit/development

Fixes scope name comparison.

Fixes #473

Author: Kapil Borle

Engine/Helper.cs

@@ -101,9 +101,9 @@ internal set
         /// </summary>
         private Dictionary<Ast, VariableAnalysis> VariableAnalysisDictionary;
 
-        private string[] functionScopes = new string[] { "global:", "local:", "script:", "private:" };
+        private string[] functionScopes = new string[] { "global:", "local:", "script:", "private:"};
 
-        private string[] variableScopes = new string[] { "global:", "local:", "script:", "private:", "variable:", ":" };
+        private string[] variableScopes = new string[] { "global:", "local:", "script:", "private:", "variable:", ":"};
 
         #endregion
 
@@ -420,7 +420,8 @@ private string NameWithoutScope(string name, string[] scopes)
             foreach (string scope in scopes)
             {
                 // trim the scope part
-                if (name.IndexOf(scope) == 0)
+                if (name.IndexOf(scope, StringComparison.OrdinalIgnoreCase) == 0) 
+
                 {
                     return name.Substring(scope.Length);
                 }
@@ -3026,4 +3027,4 @@ public object VisitUsingExpression(UsingExpressionAst usingExpressionAst)
             return null;
         }
     }
-}
+}

Tests/Rules/GoodCmdlet.ps1

@@ -223,6 +223,21 @@ function global:Get-SimpleFunc*
 
 }
 
+function Local:Get-SimpleFunc*
+{
+
+}
+
+function PRIVATE:Get-SimpleFunc*
+{
+
+}
+
+function ScRiPt:Get-SimpleFunc*
+{
+
+}
+
 <#
 .Synopsis
    Short description