Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to mark time spent not to be accounted #943

Open
marien-probesys opened this issue Jan 29, 2025 · 0 comments
Open

Allow to mark time spent not to be accounted #943

marien-probesys opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
ready ✅ You can work on this! topic: contracts All the stuff related to the contracts topic: ticketing All the stuff related to the tickets
Milestone

Comments

@marien-probesys
Copy link
Member

marien-probesys commented Jan 29, 2025

Problem

Agents may spend time for trivial tasks. In these cases, we not always want to account this time on a contract.

Solution

Allow commercials to mark a time spent as not accountable.

Specifications

Add a boolean field to the TimeSpent entity: mustBeUnaccounted, false by default.

Add a checkbox to the App\Form\TimeSpentForm labeled as "Mark this time as not to be accounted".

If the checkbox is checked, then make sure to unaccount the TimeSpent using the App\Service\ContractTimeAccounting::unaccountTimeSpents() method.

In App\Service\ContractTimeAccounting::accountTimeSpents(), skip the TimeSpents with mustBeUnaccounted = true.

Estimated time

1 day

@marien-probesys marien-probesys added topic: contracts All the stuff related to the contracts topic: ticketing All the stuff related to the tickets labels Jan 29, 2025
@marien-probesys marien-probesys added the ready ✅ You can work on this! label Jan 31, 2025
@marien-probesys marien-probesys self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ✅ You can work on this! topic: contracts All the stuff related to the contracts topic: ticketing All the stuff related to the tickets
Projects
None yet
Development

No branches or pull requests

1 participant