Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper handling of UTF-8 in MapEditor code #18

Open
JeroenDeDauw opened this issue Mar 28, 2014 · 1 comment
Open

Improper handling of UTF-8 in MapEditor code #18

JeroenDeDauw opened this issue Mar 28, 2014 · 1 comment

Comments

@JeroenDeDauw
Copy link
Member

Import from https://bugzilla.wikimedia.org/show_bug.cgi?id=42620

sprintf() used in the code for Special:MapEditor (now moved to Maps/includes/editor/EditorHtml.php) doesn't handle UTF-8 properly.

Seems to me that this problem causes "Uncaught SyntaxError: Unexpected token ILLEGAL" to appear in the console when using the googlemapsEditor forminput in http://openurbandev.com/index.php?title=Special:FormEdit/Address/Home
and hence on saving the page weird things happen like redirection to Homepage

Also the coding styles are not followed here.

see http://www.php.net/manual/en/function.sprintf.php#86304

-- Nischay Nahata 2012-12-02 11:02:09 UTC

@JeroenDeDauw
Copy link
Member Author

I will not fix this myself, though welcome contributions. You can also contract me via https://professional.wiki to do the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant