Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images in map result formats #479

Open
Rudloff opened this issue Oct 5, 2018 · 3 comments
Open

Support images in map result formats #479

Rudloff opened this issue Oct 5, 2018 · 3 comments

Comments

@Rudloff
Copy link

Rudloff commented Oct 5, 2018

Setup

  • Maps version: 5.6
  • MW version: 1.31.1
  • PHP version: 7.0.30-0+deb9u1
  • SMW version (if applicable): 3.0.0-rc.2

Issue

When a page has an image property, it is possible to display it in a list of results when using formats like table.
However, it is not possible to do the same thing when displaying results as a Leaflet map. The map marker popup does not display the image.

Here is an example: https://sandbox.semantic-mediawiki.org/wiki/Issue/M/479

@JeroenDeDauw
Copy link
Member

JeroenDeDauw commented Oct 6, 2018

Thanks for reporting and creating the example!

Two questions you can answer to make it easier to fix this:

  • Is this specific to Leaflet?
  • Is this specific to SMW results or also in display_map?

@Rudloff Rudloff changed the title Can't display an image in Leaflet popup Can't display an image in maps popup Oct 6, 2018
@Rudloff
Copy link
Author

Rudloff commented Oct 6, 2018

  • It also does not work wit Google Maps. (I updated the sandbox to show that as well.)
  • It is possible to add an image to the popup content with display_map (but the result is a bit buggy).

@JeroenDeDauw
Copy link
Member

Thanks for testing!

@JeroenDeDauw JeroenDeDauw changed the title Can't display an image in maps popup Support images in map result formats Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants