Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing GeoPolygonValue DataValues, upgrade from SemanticMaps to Maps #548

Closed
rijvirajib opened this issue Jul 4, 2019 · 1 comment
Closed
Labels

Comments

@rijvirajib
Copy link

rijvirajib commented Jul 4, 2019

Setup

  • Maps version: ~7.1
  • MW version: 1.31 LTS
  • PHP version: PHP 7.2.14
  • SMW version (if applicable): ~3.0

Issue

Possibly related to #239 .

Upgrading from MediaWiki LTS 1.27 to LTS 1.31.
SemanticMaps has been merged into Maps (as per the docs).

I have an extension that uses Geometry and PolygonValues. It used to be that Maps had Maps\Semantic\DataValues\GeoPolygonValue but this has been removed. Is there any documentation on how to migrate from SemanticMaps to Maps ~7.0.0 and use GeoPolygonValue?

I extend CoordinateValue and PolygonValue for some datatypes:

       public static function spgfInitGeoDataTypes() {
		SMW\DataTypeRegistry::getInstance()->registerDatatype(
			'_geo',
			PostGISPointValue::class,
			SMWDataItem::TYPE_GEO
		);
		SMW\DataTypeRegistry::getInstance()->registerDatatype(
			'_gpo',
			PostGISPolygonValue::class,
			SMWDataItem::TYPE_BLOB
		);
		SMW\DataTypeRegistry::getInstance()->registerDatatype(
			'_gmy',
			PostGISPolygonValue::class,
			SMWDataItem::TYPE_BLOB
		);
		return true;
	}
@JeroenDeDauw
Copy link
Member

This code was removed because the features that used it where broken for over 2 years without anyone complaining. Both the code and features are not present in the latest version of Maps so there is no migration path.

You can just copy the code you are using from the old version of Maps / Semantic Maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants