Skip to content

Plasmamen can now enable wizard and nukie in there customization screen#1018

Open
SirCannonFodder wants to merge 9 commits into
ProjectOmu:masterfrom
SirCannonFodder:plasmaman-fix
Open

Plasmamen can now enable wizard and nukie in there customization screen#1018
SirCannonFodder wants to merge 9 commits into
ProjectOmu:masterfrom
SirCannonFodder:plasmaman-fix

Conversation

@SirCannonFodder

@SirCannonFodder SirCannonFodder commented May 24, 2026

Copy link
Copy Markdown
Contributor

…en since speciesOverride will turn them into humans anyway.

About the PR

I removed Plasmamen from wizard and nukie blacklist for the customization screen and added speciesOverride to Apprentice to avoid a bad edge if a plasmaman gotten a Apprentice ghost role

Why / Balance

  • Plasmamen are already on the speciesOverride blacklist for wizard and nukie, turning them human when they get it. The blacklist in the customization screen is not only redundant but also needlessly stops Plasmamen players from ever rolling wizard and nukie.
    SpeciesOverride blacklist should be used for non-traitor antags
    Customization screen blacklist should be used for traitor antags

Technical details

I removed a few lines and copied the speciesOverride from wizard onto apprentice

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: Plasmamen can now enable wizard and nukie in there customization screen since speciesOverride will turn them human anyway.

…en since speciesOverride will turn them into humans anyway.
@github-actions github-actions Bot added the S: Untriaged Has not been set a status; currently not labeled. label May 24, 2026
@github-actions github-actions Bot added Changes: No C# Purely YAML/non-C#. and removed size/S labels May 24, 2026
@Raze500 Raze500 added A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Has not been set a status; currently not labeled. labels May 24, 2026

@Thesia000 Thesia000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thigns out instead of removing them and add a #omu coment after every changed line thx

…ion screen since speciesOverride will turn them into humans anyway."

This reverts commit 7388bdc.
@SirCannonFodder SirCannonFodder requested a review from Thesia000 June 6, 2026 23:31
@github-actions github-actions Bot added the S: Needs Review Needs review by a maintainer. label Jun 6, 2026
@NotActuallyMarty

Copy link
Copy Markdown
Contributor

lgtm you coulda done this upstream then no need for comments ngl

@github-actions github-actions Bot added the S: Needs Second Approval Approved by another maintainer, just needs one more to check it. label Jun 7, 2026

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omu comments

Comment thread Resources/Prototypes/_Goobstation/Wizard/gamerules_wizard.yml Outdated
Co-authored-by: feistyfedora <12000170+feistyfedora@users.noreply.github.com>

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions github-actions Bot added S: Approved This PR has been approved. and removed S: Needs Review Needs review by a maintainer. S: Needs Second Approval Approved by another maintainer, just needs one more to check it. labels Jun 9, 2026
@feistyfedora feistyfedora enabled auto-merge (squash) June 9, 2026 01:17
@feistyfedora feistyfedora disabled auto-merge June 9, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Purely YAML/non-C#. S: Approved This PR has been approved. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants