remove nigel plushies#1064
Conversation
|
who tf |
NotActuallyMarty
left a comment
There was a problem hiding this comment.
Comment out the lines in the yaml file rather than deleting them otherwise when merging changes to that file it'll be added back in when upstreaming without merge conflicts
instead of doing
(...)
id: Plushie -> <deleted>
name: Plushiename-> <deleted>
(...)
do:
(...)
# id: Plushie # This is a yaml comment
# name: Plushiename
(...)
No point in deleting the files either if nothing is using it, otherwise same applies as last, it'll get re-added if anything touches those files upstream. discard those changes.
Same with the comments if its already commented out keep as-is otherwise an upstream merge will most likely re-merge it un-commented causing errors.
removing from maps is fine as we're not upstreaming those
add it to migrations.yml replacing with null as: PlushieNigel: null
discard changes on the json for the same reasons
TLDR:
comment out instead of delete for upstream reasons it'll have the same effect. If you want it gone from files for whatever reason make a PR upstream.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
SIIIIIIIGHHHHHHHHH |
|
Im fixing this tomorrow |

About the PR
Removed them.
Why / Balance
Technical details
deleted yaml
Media
Requirements
Breaking changes
Changelog
🆑 Mariki