Skip to content

Commit 328ece7

Browse files
authored
Added logs for Project and Organization Endpoint (#292)
* logs added for project and organization * change warning level to error
1 parent fcfc05f commit 328ece7

File tree

4 files changed

+50
-5
lines changed

4 files changed

+50
-5
lines changed

backend/app/api/routes/organization.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import logging
12
from typing import Any, List
23

34
from fastapi import APIRouter, Depends, HTTPException
@@ -18,6 +19,7 @@
1819
from app.crud.organization import create_organization, get_organization_by_id
1920
from app.utils import APIResponse
2021

22+
logger = logging.getLogger(__name__)
2123
router = APIRouter(prefix="/organizations", tags=["organizations"])
2224

2325

@@ -59,6 +61,7 @@ def read_organization(*, session: SessionDep, org_id: int):
5961
"""
6062
org = get_organization_by_id(session=session, org_id=org_id)
6163
if org is None:
64+
logger.error(f"[read_organization] Organization not found | org_id={org_id}")
6265
raise HTTPException(status_code=404, detail="Organization not found")
6366
return APIResponse.success_response(org)
6467

@@ -74,6 +77,9 @@ def update_organization(
7477
):
7578
org = get_organization_by_id(session=session, org_id=org_id)
7679
if org is None:
80+
logger.error(
81+
f"[update_organization] Organization not found | 'org_id': {org_id}"
82+
)
7783
raise HTTPException(status_code=404, detail="Organization not found")
7884

7985
org_data = org_in.model_dump(exclude_unset=True)
@@ -82,7 +88,9 @@ def update_organization(
8288
session.add(org)
8389
session.commit()
8490
session.flush()
85-
91+
logger.info(
92+
f"[update_organization] Organization Updated Successfully | 'org_id': {org.id}"
93+
)
8694
return APIResponse.success_response(org)
8795

8896

@@ -96,9 +104,14 @@ def update_organization(
96104
def delete_organization(session: SessionDep, org_id: int):
97105
org = get_organization_by_id(session=session, org_id=org_id)
98106
if org is None:
107+
logger.error(
108+
f"[delete_organization] Organization not found | 'org_id': {org_id}"
109+
)
99110
raise HTTPException(status_code=404, detail="Organization not found")
100111

101112
session.delete(org)
102113
session.commit()
103-
114+
logger.info(
115+
f"[delete_organization] Organization Deleted Successfully | 'org_id': {org_id}"
116+
)
104117
return APIResponse.success_response(None)

backend/app/api/routes/project.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import logging
12
from typing import Any, List
23

34
from fastapi import APIRouter, Depends, HTTPException, Query
@@ -6,17 +7,16 @@
67

78
from app.models import Project, ProjectCreate, ProjectUpdate, ProjectPublic
89
from app.api.deps import (
9-
CurrentUser,
1010
SessionDep,
1111
get_current_active_superuser,
1212
)
1313
from app.crud.project import (
1414
create_project,
1515
get_project_by_id,
16-
get_projects_by_organization,
1716
)
1817
from app.utils import APIResponse
1918

19+
logger = logging.getLogger(__name__)
2020
router = APIRouter(prefix="/projects", tags=["projects"])
2121

2222

@@ -62,6 +62,7 @@ def read_project(*, session: SessionDep, project_id: int):
6262
"""
6363
project = get_project_by_id(session=session, project_id=project_id)
6464
if project is None:
65+
logger.error(f"[read_project] Project not found | project_id={project_id}")
6566
raise HTTPException(status_code=404, detail="Project not found")
6667
return APIResponse.success_response(project)
6768

@@ -75,6 +76,7 @@ def read_project(*, session: SessionDep, project_id: int):
7576
def update_project(*, session: SessionDep, project_id: int, project_in: ProjectUpdate):
7677
project = get_project_by_id(session=session, project_id=project_id)
7778
if project is None:
79+
logger.error(f"[update_project] Project not found | project_id={project_id}")
7880
raise HTTPException(status_code=404, detail="Project not found")
7981

8082
project_data = project_in.model_dump(exclude_unset=True)
@@ -83,6 +85,9 @@ def update_project(*, session: SessionDep, project_id: int, project_in: ProjectU
8385
session.add(project)
8486
session.commit()
8587
session.flush()
88+
logger.info(
89+
f"[update_project] Project updated successfully | project_id={project.id}"
90+
)
8691
return APIResponse.success_response(project)
8792

8893

@@ -95,9 +100,12 @@ def update_project(*, session: SessionDep, project_id: int, project_in: ProjectU
95100
def delete_project(session: SessionDep, project_id: int):
96101
project = get_project_by_id(session=session, project_id=project_id)
97102
if project is None:
103+
logger.error(f"[delete_project] Project not found | project_id={project_id}")
98104
raise HTTPException(status_code=404, detail="Project not found")
99105

100106
session.delete(project)
101107
session.commit()
102-
108+
logger.info(
109+
f"[delete_project] Project deleted successfully | project_id={project_id}"
110+
)
103111
return APIResponse.success_response(None)

backend/app/crud/organization.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import logging
12
from typing import Any, Optional
23
from datetime import datetime, timezone
34
from sqlmodel import Session, select
@@ -6,6 +7,8 @@
67
from app.models import Organization, OrganizationCreate
78
from app.core.util import now
89

10+
logger = logging.getLogger(__name__)
11+
912

1013
def create_organization(
1114
*, session: Session, org_create: OrganizationCreate
@@ -16,6 +19,9 @@ def create_organization(
1619
session.add(db_org)
1720
session.commit()
1821
session.refresh(db_org)
22+
logger.info(
23+
f"[create_organization] Organization Created Successfully | 'org_id': {db_org.id}, 'name': {db_org.name}"
24+
)
1925
return db_org
2026

2127

@@ -37,9 +43,15 @@ def validate_organization(session: Session, org_id: int) -> Organization:
3743
"""
3844
organization = get_organization_by_id(session, org_id)
3945
if not organization:
46+
logger.error(
47+
f"[validate_organization] Organization not found | 'org_id': {org_id}"
48+
)
4049
raise HTTPException(404, "Organization not found")
4150

4251
if not organization.is_active:
52+
logger.error(
53+
f"[validate_organization] Organization is not active | 'org_id': {org_id}"
54+
)
4355
raise HTTPException("Organization is not active")
4456

4557
return organization

backend/app/crud/project.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import logging
12
from typing import List, Optional
23
from datetime import datetime, timezone
34
from sqlmodel import Session, select
@@ -6,6 +7,8 @@
67
from app.models import Project, ProjectCreate, Organization
78
from app.core.util import now
89

10+
logger = logging.getLogger(__name__)
11+
912

1013
def create_project(*, session: Session, project_create: ProjectCreate) -> Project:
1114
db_project = Project.model_validate(project_create)
@@ -14,6 +17,9 @@ def create_project(*, session: Session, project_create: ProjectCreate) -> Projec
1417
session.add(db_project)
1518
session.commit()
1619
session.refresh(db_project)
20+
logger.info(
21+
f"[create_project] Project Created Successfully | 'project_id': {db_project.id}, 'name': {db_project.name}"
22+
)
1723
return db_project
1824

1925

@@ -33,9 +39,15 @@ def validate_project(session: Session, project_id: int) -> Project:
3339
"""
3440
project = get_project_by_id(session=session, project_id=project_id)
3541
if not project:
42+
logger.error(
43+
f"[validate_project] Project not found | 'project_id': {project_id}"
44+
)
3645
raise HTTPException(404, "Project not found")
3746

3847
if not project.is_active:
48+
logger.error(
49+
f"[validate_project] Project is not active | 'project_id': {project_id}"
50+
)
3951
raise HTTPException(404, "Project is not active")
4052

4153
return project

0 commit comments

Comments
 (0)