[ Feature ] Make calling collection creation with a webhook optional (#183)

* Callback semantics based on callback URL specification

* Make payload key the collection ID

Author: jerome-white

backend/app/api/routes/collections.py

@@ -2,7 +2,7 @@
 import logging
 import warnings
 from uuid import UUID, uuid4
-from typing import Any, List
+from typing import Any, List, Optional
 from dataclasses import dataclass, field, fields, asdict, replace
 
 from openai import OpenAI, OpenAIError
@@ -67,7 +67,7 @@ class AssistantOptions(BaseModel):
 
 
 class CallbackRequest(BaseModel):
-    callback_url: HttpUrl
+    callback_url: Optional[HttpUrl] = None
 
 
 class CreationRequest(
@@ -86,9 +86,28 @@ class DeletionRequest(CallbackRequest):
 
 
 class CallbackHandler:
+    def __init__(self, payload: ResponsePayload):
+        self.payload = payload
+
+    def fail(self, body):
+        raise NotImplementedError()
+
+    def success(self, body):
+        raise NotImplementedError()
+
+
+class SilentCallback(CallbackHandler):
+    def fail(self, body):
+        return
+
+    def success(self, body):
+        return
+
+
+class WebHookCallback(CallbackHandler):
     def __init__(self, url: HttpUrl, payload: ResponsePayload):
+        super().__init__(payload)
         self.url = url
-        self.payload = payload
 
     def __call__(self, response: APIResponse, status: str):
         time = ResponsePayload.now()
@@ -125,7 +144,10 @@ def do_create_collection(
     payload: ResponsePayload,
 ):
     client = OpenAI(api_key=settings.OPENAI_API_KEY)
-    callback = CallbackHandler(request.callback_url, payload)
+    if request.callback_url is None:
+        callback = SilentCallback(payload)
+    else:
+        callback = WebHookCallback(request.callback_url, payload)
 
     #
     # Create the assistant and vector store
@@ -160,6 +182,7 @@ def do_create_collection(
 
     collection_crud = CollectionCrud(session, current_user.id)
     collection = Collection(
+        id=UUID(payload.key),
         llm_service_id=assistant.id,
         llm_service_name=request.model,
     )