Minor cleanup in benchmark test.

Signed-off-by: Arris Ray <[email protected]>

Author: arris-ray

tests/Test/Benchmark/BenchmarkTest.php

@@ -21,7 +21,7 @@ public static function setUpBeforeClass(): void
     {
         file_put_contents(
             self::RESULT_FILENAME,
-            implode(',', TestCaseResult::getCsvHeaders())
+            implode(',', TestCaseResult::getCsvHeaders()) . PHP_EOL
         );
         parent::setUpBeforeClass();
     }
@@ -32,34 +32,34 @@ public static function setUpBeforeClass(): void
     public function benchmarkProvider(): array
     {
         return [
-            [AdapterType::REDISNG, MetricType::COUNTER, 1000, 10],
-            [AdapterType::REDISNG, MetricType::COUNTER, 2000, 10],
-            [AdapterType::REDISNG, MetricType::COUNTER, 5000, 10],
-            [AdapterType::REDISNG, MetricType::COUNTER, 10000, 10],
-            [AdapterType::REDISNG, MetricType::GAUGE, 1000, 10],
-            [AdapterType::REDISNG, MetricType::GAUGE, 2000, 10],
-            [AdapterType::REDISNG, MetricType::GAUGE, 5000, 10],
-            [AdapterType::REDISNG, MetricType::GAUGE, 10000, 10],
-            [AdapterType::REDISNG, MetricType::HISTOGRAM, 1000, 10],
-            [AdapterType::REDISNG, MetricType::HISTOGRAM, 2000, 10],
-            [AdapterType::REDISNG, MetricType::HISTOGRAM, 5000, 10],
-            [AdapterType::REDISNG, MetricType::HISTOGRAM, 10000, 10],
-            [AdapterType::REDISNG, MetricType::SUMMARY, 1000, 10],
-            [AdapterType::REDISNG, MetricType::SUMMARY, 2000, 10],
-            [AdapterType::REDISNG, MetricType::SUMMARY, 5000, 10],
-            [AdapterType::REDISNG, MetricType::SUMMARY, 10000, 10],
-            [AdapterType::REDISTXN, MetricType::COUNTER, 1000, 10],
-            [AdapterType::REDISTXN, MetricType::COUNTER, 2000, 10],
-            [AdapterType::REDISTXN, MetricType::COUNTER, 5000, 10],
-            [AdapterType::REDISTXN, MetricType::COUNTER, 10000, 10],
-            [AdapterType::REDISTXN, MetricType::GAUGE, 1000, 10],
-            [AdapterType::REDISTXN, MetricType::GAUGE, 2000, 10],
-            [AdapterType::REDISTXN, MetricType::GAUGE, 5000, 10],
-            [AdapterType::REDISTXN, MetricType::GAUGE, 10000, 10],
-            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 1000, 10],
-            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 2000, 10],
-            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 5000, 10],
-            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 10000, 10],
+//            [AdapterType::REDISNG, MetricType::COUNTER, 1000, 10],
+//            [AdapterType::REDISNG, MetricType::COUNTER, 2000, 10],
+//            [AdapterType::REDISNG, MetricType::COUNTER, 5000, 10],
+//            [AdapterType::REDISNG, MetricType::COUNTER, 10000, 10],
+//            [AdapterType::REDISNG, MetricType::GAUGE, 1000, 10],
+//            [AdapterType::REDISNG, MetricType::GAUGE, 2000, 10],
+//            [AdapterType::REDISNG, MetricType::GAUGE, 5000, 10],
+//            [AdapterType::REDISNG, MetricType::GAUGE, 10000, 10],
+//            [AdapterType::REDISNG, MetricType::HISTOGRAM, 1000, 10],
+//            [AdapterType::REDISNG, MetricType::HISTOGRAM, 2000, 10],
+//            [AdapterType::REDISNG, MetricType::HISTOGRAM, 5000, 10],
+//            [AdapterType::REDISNG, MetricType::HISTOGRAM, 10000, 10],
+//            [AdapterType::REDISNG, MetricType::SUMMARY, 1000, 10],
+//            [AdapterType::REDISNG, MetricType::SUMMARY, 2000, 10],
+//            [AdapterType::REDISNG, MetricType::SUMMARY, 5000, 10],
+//            [AdapterType::REDISNG, MetricType::SUMMARY, 10000, 10],
+//            [AdapterType::REDISTXN, MetricType::COUNTER, 1000, 10],
+//            [AdapterType::REDISTXN, MetricType::COUNTER, 2000, 10],
+//            [AdapterType::REDISTXN, MetricType::COUNTER, 5000, 10],
+//            [AdapterType::REDISTXN, MetricType::COUNTER, 10000, 10],
+//            [AdapterType::REDISTXN, MetricType::GAUGE, 1000, 10],
+//            [AdapterType::REDISTXN, MetricType::GAUGE, 2000, 10],
+//            [AdapterType::REDISTXN, MetricType::GAUGE, 5000, 10],
+//            [AdapterType::REDISTXN, MetricType::GAUGE, 10000, 10],
+//            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 1000, 10],
+//            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 2000, 10],
+//            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 5000, 10],
+//            [AdapterType::REDISTXN, MetricType::HISTOGRAM, 10000, 10],
             [AdapterType::REDISTXN, MetricType::SUMMARY, 1000, 10],
             [AdapterType::REDISTXN, MetricType::SUMMARY, 2000, 10],
             [AdapterType::REDISTXN, MetricType::SUMMARY, 5000, 10],

tests/Test/Benchmark/MetricType.php

@@ -25,7 +25,7 @@ public static function toString(int $type): string
 			case MetricType::HISTOGRAM:
 				return 'histogram';
 			case MetricType::SUMMARY:
-				return 'timer';
+				return 'summary';
 		}
 
 		throw new InvalidArgumentException("Invalid adapter type: {$type}");

tests/Test/Benchmark/TestCase.php

@@ -257,7 +257,7 @@ private function emitMetric(): string
                 $registry->getOrRegisterHistogram(self::DEFAULT_METRIC_NAMESPACE, $key, self::DEFAULT_METRIC_HELP)->observe($value);
 				break;
 			case MetricType::SUMMARY:
-				$key = uniqid('timer_', false);
+				$key = uniqid('summary_', false);
                 $value = random_int(1, PHP_INT_MAX);
                 $registry->getOrRegisterSummary(self::DEFAULT_METRIC_NAMESPACE, $key, self::DEFAULT_METRIC_HELP)->observe($value);
 				break;