make NodeType.groups public

[YousefED]

I noticed NodeType.groups is marked as internal: https://github.com/ProseMirror/prosemirror-model/blob/a57531574336d00df43a68e3a2f69582b426033e/src/schema.ts#L62.

I think it can be quite useful for consumers in case nodes are part of multiple groups. Makes sense to expose it so that types are properly exported? Or is there a specific reason it's marked as internal?

[marijnh]

What is the use case where you need to enumerate the groups a node is part of? The general idea behind groups is that they allow you query whether a node is part of a given group with .is(). I haven't run into a situation where I need to find a node's groups.

[YousefED]

That'd be my use-case indeed. Which .is() do you mean? I feel like I'm missing something obvious but I don't see it on Node or NodeType

[marijnh]

NodeType.is, which accepts both node names and group names.

[YousefED]

I think you're referring to the lezer docs. As far as I see from browsing Prosemirror source code / types / docs it's not available in prosemirror?

[marijnh]

Wow, indeed, I was somewhere else entirely—wrong NodeType class for this repository.

Would an isInGroup(group: string) => boolean method cover your use case?

[YousefED]

Ha I thought I was going crazy!

Yes your suggestion would be perfect 👍

[marijnh]

Done in attached patch.