We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrollToSelection
startDOM
scrollToSelection() { let startDOM = this.domSelectionRange().focusNode! // ... }
Context
Expected Instance A DOM node is scrolled to selection
Actual Instance B DOM node is scrolled to selection
Problem domSelectionRange().focusNode! resolves to Instance A even if it was called from Instance B.
domSelectionRange().focusNode!
Proposed Solution Check if resolved startDOM matches current instance. If not result in noop.
The text was updated successfully, but these errors were encountered:
ProseMirror/prosemirror-view@d7678fb
Indeed, that doesn't look right. Attached patch adds a check.
Sorry, something went wrong.
I'm very impressed by 30 minutes turnaround from filling an issue and a fix landing on master, mind blowing 🤯
Thanks, Marjin!
No branches or pull requests
Context
scrollToSelection
Expected
Instance A DOM node is scrolled to selection
Actual
Instance B DOM node is scrolled to selection
Problem
domSelectionRange().focusNode!
resolves to Instance A even if it was called from Instance B.Proposed Solution
Check if resolved
startDOM
matches current instance. If not result in noop.The text was updated successfully, but these errors were encountered: