Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prosemirror-view: Using the private eq method in the Decoration class #827

Open
dddotsev opened this issue Aug 2, 2018 · 1 comment
Open

Comments

@dddotsev
Copy link

dddotsev commented Aug 2, 2018

Issue details

Currently the eq method in the Decoration class is private, while it is very useful when you need to compare different Decorations, that have been returned by the DecorationSet.find method. So maybe it would be a good idea to make it public. I'm somewhat new to ProseMirror, so maybe I'm missing something.
https://github.com/ProseMirror/prosemirror-view/blob/ea3d704a1796e611c2a411f16d2a6b6f58c14ce5/src/decoration.js#L98

ProseMirror version

1.3.0

@marijnh
Copy link
Member

marijnh commented Mar 18, 2020

Could you say a bit more about the use case that requires you to compare decorations in client code? (Or if this is no longer an issue, let me know.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants