Update node's attrs without affect history.

[latin-1]

What I want to do

1. Insert a image node with attributes { uploader: {...} }
2. Uploading Image
3. After upload complete, change image node's attributes to { uploader: null, image: '...' }
   (w/ or w/o .setMeta("addToHistory", true))
4. Press Command + Z

Expected behavior

Undo should delete the image node.

Actual behavior

Undo will let that image node back to uploading status / do nothing. (depends on the value of addToHistory)

Problem

There's no way to change attributes of a node. Instead, it will replace it with a new node. Because that, saveToHistory doesn't work as what I expected.

[latin-1]

https://nightingale-editor.netlify.com/

Here's the demo.

[marijnh]

Assuming that when you say "saveToHistory" you mean "addToHistory". Is the update coming more then newGroupDelay (defaults to 500ms) after the initial add? That is indeed somewhat problematic.

The recommended way to do placeholder nodes it to have an addon create a widget decoration for the placeholder, and not actually add it to the document, as in this example. Is there a reason that doesn't work for you?

[latin-1]

Assuming that when you say "saveToHistory" you mean "addToHistory".

Yes

---

No, decoration doesn't satisfy my needs. I want to make it selectable, draggable, and editable (e.g. could be align to left / right) even during uploading.

[jljorgenson18]

Ran into this. If you set "addToHistory" to false, the undo stack is essentially blocked because "setNodeMarkup" creates a new Node. The way we got around it was to use @marijnh's example at https://discuss.prosemirror.net/t/preventing-image-placeholder-replacement-from-being-undone/1394

You essentially create a custom step that updates the attributes without creating a brand new node. Then, it should work as intended.

[latin-1]

@jljorgenson18 Thanks a lot!

@marijnh Could you please add this step into the core library? Thanks!