Skip to content

feature: Migrate routing to a "Lesson Route" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeal opened this issue Jul 25, 2018 · 3 comments
Closed

feature: Migrate routing to a "Lesson Route" #12

mikeal opened this issue Jul 25, 2018 · 3 comments
Labels

Comments

@mikeal
Copy link
Member

mikeal commented Jul 25, 2018

Right now, you have to manually add a route for every step in your lesson.

We should move to a more dynamic route that:

  1. Automatically detects how many lesson steps you have to lays them out.
  2. Can alter the "Next lesson" button on the last step so that it bounces you back to the index instead.
@terichadbourne
Copy link
Member

@mikeal Regarding the second step, note that I already made a conditional button that can bounce you back to the index if it's the last lesson in the series. However, it requires manually passing a last: 'true; in the right lesson of each series when you develop it. The commit is part of this PR that's awaiting another review before being merged.

I don't yet know enough about routing and Vue to tackle the first step, which I agree would be a more elegant solution (auto-detecting the number of lessons in the series), but I'm happy to attempt that once I'm more familiar.

@terichadbourne terichadbourne changed the title chore: Migrate routing to a "Lesson Route" feature: Migrate routing to a "Lesson Route" Nov 9, 2018
@terichadbourne
Copy link
Member

Update: You no longer have to add last: true in the last lesson of the series. The button code can correctly determine whether you're in the last lesson without that now. You do still have to create a route for each lesson in the current setup, so this issue is still open, to be addressed after 1.0.

@mikeal
Copy link
Member Author

mikeal commented Dec 7, 2018

We can probably close this now, the main purpose of the issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants