Configure linter and run it on CI

[olizilla]

Comming from standard js world, I'd expect double quotes for strings to get picked up by the lint script. This came up in a PR #63 (comment)

We need to

• add npm run lint to the travis config so we get feedback on PRs
• figure out why the vue-cli-service lint reports no lint errors when mixed quote styles are used.

[terichadbourne]

Is it possible this particular case wasn't picked up as an error by the linter because the string had an apostrophe inside it and couldn't have been produced with single quotes surrounding it? If so, maybe there's a way to add our own rule to require ` instead of " around the string in that case?

[mikeal]

Is it possible this particular case wasn't picked up as an error by the linter because the string had an apostrophe inside it and couldn't have been produced with single quotes surrounding it?

This is absolutely why :)

[terichadbourne]

Does this mean this issue should be closed, or do we want to teach the linter to demand backticks instead of double quotes? If so, I'd appreciate someone else picking up that task, or walking me through how to teach a linter new tricks.

…

On Tue, Oct 30, 2018 at 7:14 PM Mikeal Rogers ***@***.***> wrote: Is it possible this particular case wasn't picked up as an error by the linter because the string had an apostrophe inside it and couldn't have been produced with single quotes surrounding it? This is absolutely why :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASSIib9u2HavWCR9ynRI0V4U_rYvWB17ks5uqN1vgaJpZM4X_ZUA> .

-- *Teri Chadbourne, CMP* Community Manager Protocol Labs <https://protocol.ai/> Twitter <https://twitter.com/eventteri> | GitHub <https://github.com/terichadbourne>

[mikeal]

This still needs to be tackled: " add npm run lint to the travis config so we get feedback on PRs"

However, it's a little more involved than that. Our current travis config is for gh-pages deploys so it doesn't run on every PR, it only runs on merges to master.

[terichadbourne]

May I assign this one to you @mikeal so I can stay focused on site content for the time being? (Happy to have you grab me when you're doing it if you want to show me how it works; I don't know anything about this kind of plumbing.)

[mikeal]

Sure, I'll assign it to myself to save you the hassle :)