Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages when TerminatedWorkerException is thrown #277

Open
MichaelHatherly opened this issue Mar 7, 2025 · 1 comment
Open
Labels
enhancement New feature or request error handling

Comments

@MichaelHatherly
Copy link
Collaborator

Based on #276 the underlying error was difficult to debug since it was hidden. Improve the capture of errors from the worker processes that get killed.

@MichaelHatherly MichaelHatherly added enhancement New feature or request error handling labels Mar 7, 2025
@MichaelHatherly
Copy link
Collaborator Author

MichaelHatherly commented Mar 7, 2025

Some bits of info from having a look into this:

  • would need to pipeline the Cmd in
    proc = open(Cmd(cmd; detach = true, windows_hide = true), "w+")
    and capture stderr
  • this is made more difficult since the likely place where code that would cause the process to get killed (via segfaulting perhaps) would be inside user code written in a cell. When that code is evaluated we have set stderr to a redirected pipe in IOCapture which captures that error (perhaps?) and thus it isn't forwarded to the stderr set in the server's pipeline in point one. Would likely need to also feed it through via passthrough keyword, but that sends it all to stdout (which is what Malt uses to communicate with the server..., uses a Socket, not stdout, that just gets used for the initial port number setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request error handling
Projects
None yet
Development

No branches or pull requests

1 participant