Mh/all tables support #286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
===========================================
+ Coverage 66.12% 79.48% +13.36%
===========================================
Files 58 39 -19
Lines 2816 2062 -754
===========================================
- Hits 1862 1639 -223
+ Misses 954 423 -531 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MichaelHatherly Thank you! I had similar ideas; I've just updated my PR with the _has_trait(trait, obj)/_ojs_convert(trait, obj), |
added 3 commits
March 22, 2025 12:16
- implement the generic _has_trait(trait, obj), _obj_convert(trait, obj) mechanism for potential future extensions - QuartoNotebookWorkerDataFramesTablesExt: drop DataFrames dependency
should lower the memory footprint.
MichaelHatherly
force-pushed
the
mh/all_tables_support
branch
2 times, most recently
from
8e4f903 to
b17ddf3
Compare
MichaelHatherly
force-pushed
the
mh/all_tables_support
branch
from
b17ddf3 to
70cea70
Compare
MichaelHatherly
force-pushed
the
mh/all_tables_support
branch
from
8a2827d to
59600aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alyst, this is the kind of approach needed to move
Tablesto an extension rather than required dep. Feel free to pull these changes into your branch. Not heavily tested this, but the general approach should work out well.