Merge pull request #70 from Puresyn/development

Development

Author: Puresyn

Core/CharacterInfo.lua

@@ -127,7 +127,7 @@ function CharacterInfo:GetMyCharacterInfo()
     local seasonMaps = DungeonTools:GetCurrentSeasonMaps()
     for mapid, v in pairs(seasonMaps) do
         local keyRun = {}
-        
+
         -- empty data set
         local emptyData = {
             Rating = 0, -- rating
@@ -141,16 +141,21 @@ function CharacterInfo:GetMyCharacterInfo()
             keyRun["bestOverall"] = 0
             keyRun["DungeonData"] = emptyData            
         else
-            local dungeonDetails = {
-                ["Rating"] = DungeonTools:CalculateRating(mapid, mapScore[1].level, mapScore[1].durationSec),
-                ["Level"] = mapScore[1].level,
-                ["DurationSec"] = mapScore[1].durationSec,
-                ["overTime"] = mapScore[1].overTime
-            }
-            keyRun["bestOverall"] = bestOverallScore
-            keyRun["DungeonData"] = dungeonDetails
+            for i,v in pairs(mapScore) do
+                -- Only gets the highest score data, instead of each data set for level 4 affix.
+                if (v.score == bestOverallScore) then
+                    local dungeonDetails = {
+                        ["Rating"] = DungeonTools:CalculateRating(mapid, v.level, v.durationSec),
+                        ["Level"] = v.level,
+                        ["DurationSec"] = v.durationSec,
+                        ["overTime"] = v.overTime
+                    }
+                    keyRun["DungeonData"] = dungeonDetails
+                end
+            end
+            
+            keyRun["bestOverall"] = bestOverallScore        
         end 
-
         myCharacterInfo.DungeonRuns[mapid] = keyRun       
     end
 

Core/UI/WhatsNew.lua

@@ -25,38 +25,16 @@ local function setWhatsNewContent(parent)
                 <h1>|cff]]..h1Color..[[News / Updates / Patch Notes|r</h1>
                 <p>]]..KeyMasterLocals.DISPLAYVERSION..KM_AUTOVERSION.." "..KM_VERSION_STATUS..[[</p>
                 <br/>
-                <h2>|cff]]..h2Color..[[1.3.3 HOTFIX:|r</h2>
-                <p>- Fixed French clients having problems loading Key Master.</p>
-                <br/>
-                <br/>
-                <h2>|cff]]..h2Color..[[1.3.1 HOTFIX:|r</h2>
-                <p>- Fixed an error for new users of keymaster that would cause Key Master not to load properly.</p>
-                <br/>
-                <br/>
-                <h2>|cff]]..h2Color..[[Fixes (1.3.0):|r</h2>
-                <p>- Fixed lua error when joining a party with someone that has a newer version of Key Master.</p>
+                <h2>|cff]]..h2Color..[[Fixes:|r</h2>
+                <p>- Fixed an issue where the week by week ratings were not properly updating.</p>
                 <br/>
                 <br/>
                 <h2>|cff]]..h2Color..[[Updates:|r</h2>
-                <p>- Due to drastic API changes - all character data is reset/removed on first load of 1.3.0. Log into each character to refresh.</p>
-                <br/>
-                <p>- Changed data structure since mythic plus data no longer is kept by tran/fort criteria.</p>
-                <br/>
-                <p>- Remapped UI elements on player and party frame to use newly created data structure.</p>
-                <br/>
-                <p>- Added backward compatibility check to 1.2.5 and older to ignore data since structures are different.</p>
-                <br/>
-                <p>- Changed player and party data frames to update when an score gained event happens from a mythic plus dungeon.</p>
-                <br/>
-                <p>- Updated rating calculator on player frame for the new mythic plus rating system (Big thanks to OMGTOTEM's contribution!).</p>
-                <br/>
-                <p>- Temporality changed the player frame to a new layout since tyran/fort is no longer a thing.</p>
-                <br/>
-                <p>- Adjusted the "What's New" content for easier readability.</p>
+                <p>- None</p>
                 <br/>
                 <br/>
                 <h2>|cff]]..h2Color..[[Known Bugs/Issues:|r</h2>
-                <p>- Party members running an older version of KM may experience LUA errors when grouped with someone running 1.3.0 or greater. Ask them to update!</p>
+                <p>- Rating calculations are still being verified</p>
                 <br/>
                 <br/>
                 <p>If you experience any other issues, please report them with as much detail as possible in the Key Master Issues GitHub.</p>
@@ -179,4 +157,4 @@ function WhatsNew:Init()
     HTMLcontent:SetHeight(HTMLcontent:GetContentHeight()+12)
 
     return noticeFrame
-end
+end

KeyMaster.lua

@@ -298,4 +298,4 @@ end
 
 local keystoneOpenEvents = CreateFrame("Frame")
 keystoneOpenEvents:RegisterEvent("CHALLENGE_MODE_KEYSTONE_RECEPTABLE_OPEN")
-keystoneOpenEvents:SetScript("OnEvent", OnEvent_OnKeystoneOpen)
+keystoneOpenEvents:SetScript("OnEvent", OnEvent_OnKeystoneOpen)

KeyMaster.toc

@@ -2,7 +2,7 @@
 ## X-Max-Interface: 110002
 ## X-Min-Interface: 110002
 
-## Version: 1.3.3
+## Version: 1.3.4
 ## Title: |cffb09c60Key Master|r
 ## Title-ptBR: |cffb09c60Key Master|r
 ## Title-ruRU: |cffb09c60Key Master|r [|cffe6b080Мастер ключей|r]

PatchNotes.txt

@@ -1,6 +1,12 @@
 Key Master AddOn for World of Warcraft
 (c) 2024 – Released under the GNU General Public License
 
+PATCH NOTES:
+--------------------------------------------------
+Key Master v1.3.4
+--------------------------------------------------
+- Fixed an issue where the week by week ratings were not properly updating.
+
 PATCH NOTES:
 --------------------------------------------------
 Key Master v1.3.0-3
@@ -350,4 +356,4 @@ Key Master Beta release v0.0.93-beta
 --------------------------------------------------
 Key Master Beta release v0.0.92-beta
 --------------------------------------------------
-Initial public beta release.
+Initial public beta release.