Skip to content

Commit e4cc47d

Browse files
committed
Changed header season to expansion season instead of lifetime season. | Updated Patch notes
1 parent dd1e749 commit e4cc47d

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

Core/Localization/Localization.enUS.lua

+6
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ L.XPAC[8] = { enum = "LE_EXPANSION_SHADOWLANDS", desc = "Shadowlands" }
2525
L.XPAC[9] = { enum = "LE_EXPANSION_DRAGONFLIGHT", desc = "Dragonflight" }
2626
L.XPAC[10] = { enum = "LE_EXPANSION_11_0", desc = "The War Within" } -- enum will need updated when available
2727

28+
L.MPLUSSEASON = {}
29+
L.MPLUSSEASON[11] = { name = "Season 3" }
30+
L.MPLUSSEASON[12] = { name = "Season 4" }
31+
L.MPLUSSEASON[13] = { name = "Season 1" } -- expecting season 13 to be TWW S1
32+
L.MPLUSSEASON[14] = { name = "Season 2" } -- expecting season 13 to be TWW S2
33+
2834
L.ADDONNAME = "Key Master"
2935
L.BUILDRELEASE = "release"
3036
L.BUILDBETA = "beta"

Core/UI/HeaderFrame.lua

+4
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,12 @@ function HeaderFrame:CreateHeaderContent(parentFrame)
183183

184184
local xpacNum = GetServerExpansionLevel()
185185
local xpacDesc
186+
local seasonNum = DungeonTools:GetCurrentSeason()
186187
if (xpacNum ~= nil) then -- check the expansion number was returned
187188
xpacDesc = KeyMasterLocals.XPAC[xpacNum].desc
189+
if (xpacDesc ~= nil and seasonNum ~= nil and seasonNum > 0) then
190+
xpacDesc = xpacDesc.." "..KeyMasterLocals.MPLUSSEASON[seasonNum].name
191+
end
188192
end
189193
if (xpacDesc ~= nil) then -- if no desciption found, skip this
190194
headerContent.xpacInformation = headerContent:CreateFontString(nil, "OVERLAY", "KeyMasterFontSmall")

PatchNotes.txt

+2-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@ Key Master Beta release v0.0.95-beta
2020
- Updated the Key Master main "Theme" color to Key Master Gold.
2121
- Added a minimap icon
2222
- Added minimap icon show/hide option to configuration screen.
23-
- Because the current overall WoW season number is not marketed (i.e. Season 11) and the expansion
24-
season is (i.e. Dragonflight Season 3) -but is not available from the API-, we've replaced the
25-
overall season number in the main header with the current expansion name. (no season info) to
26-
reduce confusion.
23+
- Changed the season display in the main header to reflect the current expansion season
24+
instead of the WoW lifetime season.
2725
- Added additional back-end functionality for upcoming language localization.
2826
- Cleaned up some cross-server compatability concerns - Key Master "should" now work no differently
2927
between same server and cross-server parties.

Readme.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ location to display detailed Mythic Plus content information about you and/or yo
1616

1717
While there are many future features in-mind for Key Master to expand its
1818
usefulness, how far it may go and when that will happen is largely dependent on
19-
its user base. So, if you find Key Master useful, tell your friends!
19+
its user base. So, if you find Key Master useful, make sure to give us feeedback
20+
and tell your friends!
2021

2122
Repository: (Not yet public)
2223
For full source code, bug submission, bug tracking, and other source related

0 commit comments

Comments
 (0)