Fix all Copilot review issues in plot module

- __init__.py: use backend != "default" instead of substring test
- output.py: use format == "show" instead of substring test
- array.py: guard on array.size == 0 instead of np.all(array == 0)
  so zero-valued images (residuals, masks) still render
- array.py: compute LogNorm vmax with np.nanmax to handle NaN-containing
  arrays; guard against non-finite / degenerate ranges
- yx.py: remove np.count_nonzero(y) == 0 guard so all-zero series still
  plots; keep only None / empty / all-NaN guards
- inversion.py: compute LogNorm vmax from pixel_values (np.nanmax)
  instead of passing None, matching array.py behaviour
- inversion.py: add plt.colorbar to the InterpolatorRectangularUniform
  (imshow) branch so both rectangular paths consistently show a colorbar

https://claude.ai/code/session_01B9sVEV54XWCa2LJw1C8gvv

Author: claude

autoarray/plot/__init__.py

@@ -4,7 +4,7 @@ def _set_backend():
         from autoconf import conf
 
         backend = conf.get_matplotlib_backend()
-        if backend not in "default":
+        if backend != "default":
             matplotlib.use(backend)
         try:
             hpc_mode = conf.instance["general"]["hpc"]["hpc_mode"]

autoarray/plot/array.py

@@ -131,7 +131,7 @@ def plot_array(
     except AttributeError:
         array = np.asarray(array)
 
-    if array is None or np.all(array == 0):
+    if array is None or array.size == 0:
         return
 
     # convert overlay params (safe for None and already-numpy inputs)
@@ -165,7 +165,15 @@ def plot_array(
         except Exception:
             log10_min = 1.0e-4
         clipped = np.clip(array, log10_min, None)
-        norm = LogNorm(vmin=vmin or log10_min, vmax=vmax or clipped.max())
+        vmin_log = vmin if (vmin is not None and np.isfinite(vmin)) else log10_min
+        if vmax is not None and np.isfinite(vmax):
+            vmax_log = vmax
+        else:
+            with np.errstate(all="ignore"):
+                vmax_log = np.nanmax(clipped)
+        if not np.isfinite(vmax_log) or vmax_log <= vmin_log:
+            vmax_log = vmin_log * 10.0
+        norm = LogNorm(vmin=vmin_log, vmax=vmax_log)
     elif vmin is not None or vmax is not None:
         norm = Normalize(vmin=vmin, vmax=vmax)
     else:

autoarray/plot/inversion.py

@@ -85,7 +85,17 @@ def plot_inversion_reconstruction(
 
     # --- colour normalisation --------------------------------------------------
     if use_log10:
-        norm = LogNorm(vmin=vmin or 1e-4, vmax=vmax)
+        vmin_log = vmin if (vmin is not None and np.isfinite(vmin)) else 1e-4
+        if vmax is not None and np.isfinite(vmax):
+            vmax_log = vmax
+        elif pixel_values is not None:
+            with np.errstate(all="ignore"):
+                vmax_log = float(np.nanmax(np.asarray(pixel_values)))
+            if not np.isfinite(vmax_log) or vmax_log <= vmin_log:
+                vmax_log = vmin_log * 10.0
+        else:
+            vmax_log = vmin_log * 10.0
+        norm = LogNorm(vmin=vmin_log, vmax=vmax_log)
     elif vmin is not None or vmax is not None:
         norm = Normalize(vmin=vmin, vmax=vmax)
     else:
@@ -177,14 +187,15 @@ def _plot_rectangular(ax, pixel_values, mapper, norm, colormap, extent):
             pixel_scales=mapper.mesh_geometry.pixel_scales,
             origin=mapper.mesh_geometry.origin,
         )
-        ax.imshow(
+        im = ax.imshow(
             pix_array.native.array,
             cmap=colormap,
             norm=norm,
             extent=pix_array.geometry.extent,
             aspect="auto",
             origin="upper",
         )
+        plt.colorbar(im, ax=ax)
     else:
         y_edges, x_edges = mapper.mesh_geometry.edges_transformed.T
         Y, X = np.meshgrid(y_edges, x_edges, indexing="ij")

autoarray/plot/output.py

@@ -96,7 +96,7 @@ def output_path_from(self, format):
             Absolute path to the output directory, or ``None`` for
             ``format == "show"``.
         """
-        if format in "show":
+        if format == "show":
             return None
 
         if self.format_folder:

autoarray/plot/yx.py

@@ -83,7 +83,7 @@ def plot_yx(
         x = x.array if hasattr(x, "array") else np.asarray(x)
 
     # guard: nothing to draw
-    if y is None or np.count_nonzero(y) == 0 or np.isnan(y).all():
+    if y is None or len(y) == 0 or np.isnan(y).all():
         return
 
     owns_figure = ax is None