Skip to content

Commit 4ced7b5

Browse files
authored
Merge pull request #359 from PyAutoLabs/feature/skip-degenerate-radial-caustic
fix: skip degenerate critical curves instead of tracing phantom noise
2 parents fb0dea5 + abd7b71 commit 4ced7b5

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

autogalaxy/config/visualize/general.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ general:
55
log10_min_value: 1.0e-4
66
log10_max_value: 1.0e99
77
zoom_around_mask: true
8-
critical_curves_method: zero_contour
8+
critical_curves_method: marching_squares
99
inversion:
1010
reconstruction_vmax_factor: 0.5
1111
total_mappings_pixels: 8

autogalaxy/operate/lens_calc.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,10 @@ def tangential_critical_curve_list_from(
625625
"""
626626
tangential_eigen_values = self.tangential_eigen_value_from(grid=grid)
627627

628+
vals = tangential_eigen_values.native
629+
if vals.min() > -1e-6 or vals.max() < 1e-6:
630+
return []
631+
628632
return self.contour_list_from(grid=grid, contour_array=tangential_eigen_values)
629633

630634
@evaluation_grid
@@ -651,6 +655,10 @@ def radial_critical_curve_list_from(
651655
"""
652656
radial_eigen_values = self.radial_eigen_value_from(grid=grid)
653657

658+
vals = radial_eigen_values.native
659+
if vals.min() > -1e-6 or vals.max() < 1e-6:
660+
return []
661+
654662
return self.contour_list_from(grid=grid, contour_array=radial_eigen_values)
655663

656664
@evaluation_grid

0 commit comments

Comments
 (0)