Skip to content

Commit 59e00b9

Browse files
authored
Merge pull request #374 from Jammy2211/feature/w_tilde_via_dataset
Feature/w tilde via dataset
2 parents 7c59ab6 + 37ba243 commit 59e00b9

17 files changed

Lines changed: 32 additions & 68 deletions

File tree

autolens/aggregator/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
from autolens.aggregator.subplot import SubplotFitX1Plane as subplot_fit_x1_plane
2828
from autolens.aggregator.subplot import SubplotFit as subplot_fit
2929
from autolens.aggregator.subplot import SubplotFitLog10 as subplot_fit_log10
30-
from autolens.aggregator.subplot import FITSModelGalaxyImages as fits_model_galaxy_images
30+
from autolens.aggregator.subplot import (
31+
FITSModelGalaxyImages as fits_model_galaxy_images,
32+
)
3133
from autolens.aggregator.subplot import FITSTracer as fits_tracer
3234
from autolens.aggregator.subplot import FITSFit as fits_fit

autolens/analysis/positions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,4 +199,3 @@ def log_likelihood_penalty_from(
199199
)
200200

201201
return penalty if max_separation > self.threshold else np.array(0.0)
202-

autolens/fixtures.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,23 +88,20 @@ def make_fit_interferometer_x1_plane_7x7():
8888
return al.FitInterferometer(
8989
dataset=make_interferometer_7(),
9090
tracer=make_tracer_x1_plane_7x7(),
91-
settings_inversion=aa.SettingsInversion(use_w_tilde=False),
9291
)
9392

9493

9594
def make_fit_interferometer_x2_plane_7x7():
9695
return al.FitInterferometer(
9796
dataset=make_interferometer_7(),
9897
tracer=make_tracer_x2_plane_7x7(),
99-
settings_inversion=aa.SettingsInversion(use_w_tilde=False),
10098
)
10199

102100

103101
def make_fit_interferometer_x2_plane_inversion_7x7():
104102
return al.FitInterferometer(
105103
dataset=make_interferometer_7(),
106104
tracer=make_tracer_x2_plane_inversion_7x7(),
107-
settings_inversion=aa.SettingsInversion(use_w_tilde=False),
108105
)
109106

110107

@@ -144,7 +141,6 @@ def make_adapt_images_7x7():
144141
def make_analysis_imaging_7x7():
145142
analysis = al.AnalysisImaging(
146143
dataset=make_masked_imaging_7x7(),
147-
settings_inversion=aa.SettingsInversion(use_w_tilde=False),
148144
use_jax=False,
149145
)
150146
analysis._adapt_images = make_adapt_images_7x7()

autolens/interferometer/fit_interferometer.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ def __init__(
6363
Settings controlling how an inversion is fitted for example which linear algebra formalism is used.
6464
"""
6565

66-
try:
67-
from autoarray.inversion.inversion import inversion_util_secret
68-
except ImportError:
69-
settings_inversion.use_w_tilde = False
70-
7166
self.tracer = tracer
7267

7368
self.adapt_images = adapt_images

autolens/lens/to_inversion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def lp_linear_func_list_galaxy_dict(
175175
blurring=traced_blurring_grids_of_planes_list[plane_index],
176176
)
177177

178-
if self.settings_inversion.use_w_tilde:
178+
if self.dataset.w_tilde is not None:
179179
w_tilde = self.dataset.w_tilde
180180
else:
181181
w_tilde = None

autolens/mock.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ def deflections_between_planes_from(self, grid, xp=np, plane_i=0, plane_j=-1):
2323
return xp.zeros_like(grid.array)
2424

2525
def magnification_2d_via_hessian_from(
26-
self, grid, buffer: float = 0.01, deflections_func=None, xp=np,
26+
self,
27+
grid,
28+
buffer: float = 0.01,
29+
deflections_func=None,
30+
xp=np,
2731
) -> aa.ArrayIrregular:
2832
return aa.ArrayIrregular(values=xp.ones(grid.shape[0]))

autolens/point/fit/abstract.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ def magnifications_at_positions(self) -> aa.ArrayIrregular:
133133
"""
134134
return abs(
135135
self.tracer.magnification_2d_via_hessian_from(
136-
grid=self.positions,
137-
deflections_func=self.deflections_func,
138-
xp=self._xp
136+
grid=self.positions, deflections_func=self.deflections_func, xp=self._xp
139137
)
140138
)
141139

autolens/point/fit/positions/image/abstract.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,5 +104,5 @@ def model_data(self) -> aa.Grid2DIrregular:
104104
tracer=self.tracer,
105105
source_plane_coordinate=self.source_plane_coordinate,
106106
plane_redshift=self.plane_redshift,
107-
remove_infinities=False
107+
remove_infinities=False,
108108
)

autolens/point/mock/mock_solver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ def solve(
1010
tracer,
1111
source_plane_coordinate,
1212
plane_redshift: Optional[float] = None,
13-
remove_infinities : bool = True
13+
remove_infinities: bool = True,
1414
):
1515
return self.model_positions

autolens/point/solver/point_solver.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ def solve(
6060
tracer=tracer, points=kept_triangles.means
6161
)
6262

63-
solution = aa.Grid2DIrregular([pair for pair in filtered_means], xp=self._xp).array
63+
solution = aa.Grid2DIrregular(
64+
[pair for pair in filtered_means], xp=self._xp
65+
).array
6466

6567
is_nan = self._xp.isnan(solution).any(axis=1)
6668
sentinel = self._xp.full_like(solution[0], fill_value=self._xp.inf)

0 commit comments

Comments
 (0)