Skip to content

Fix subtle reporting bug for default on plugins - [merged] #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asottile opened this issue Apr 3, 2021 · 2 comments
Closed

Fix subtle reporting bug for default on plugins - [merged] #821

asottile opened this issue Apr 3, 2021 · 2 comments
Labels
gitlab merge request

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Nov 15, 2016, 17:52

Merges bug/257 -> master

When we refactored our decision process to fix #239, we broke a subtle
corner case where extensions that are not off-by-default are to be
reported.

This further refactors that logic and adds specific tests around it to
ensure it works as expected and doesn't regress.

Closes #257
@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Nov 15, 2016, 17:56

Added 1 commit:

  • c50b747 - Fix subtle reporting bug for default on plugins

Compare with previous version

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Nov 16, 2016, 07:44

Mentioned in commit fd1cc38

@asottile asottile closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gitlab merge request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asottile