From c8ab1ceb9158a3e0ad7221ce424514a663c30406 Mon Sep 17 00:00:00 2001 From: Rick Wierenga Date: Thu, 13 Feb 2025 11:48:05 -0800 Subject: [PATCH 1/3] pierce_foil: decrease height diff from 20mm to 15mm --- pylabrobot/liquid_handling/backends/hamilton/STAR.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pylabrobot/liquid_handling/backends/hamilton/STAR.py b/pylabrobot/liquid_handling/backends/hamilton/STAR.py index 0c91c65ad4..46bfb7d7af 100644 --- a/pylabrobot/liquid_handling/backends/hamilton/STAR.py +++ b/pylabrobot/liquid_handling/backends/hamilton/STAR.py @@ -7828,7 +7828,7 @@ async def step_off_foil( zs = await self.get_channels_z_positions() indices = [channel_idx for channel_idx, z in zs.items() if z < front_location.z] idx = { - idx: front_location.z + 20 for idx in indices if idx not in (front_channel, back_channel) + idx: front_location.z + 15 for idx in indices if idx not in (front_channel, back_channel) } await self.position_channels_in_z_direction(idx) From 03de0516b59cf34a41ba16b4592c34856631e8fb Mon Sep 17 00:00:00 2001 From: Rick Wierenga Date: Thu, 13 Feb 2025 11:50:09 -0800 Subject: [PATCH 2/3] parameterize --- pylabrobot/liquid_handling/backends/hamilton/STAR.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pylabrobot/liquid_handling/backends/hamilton/STAR.py b/pylabrobot/liquid_handling/backends/hamilton/STAR.py index 46bfb7d7af..542beb9502 100644 --- a/pylabrobot/liquid_handling/backends/hamilton/STAR.py +++ b/pylabrobot/liquid_handling/backends/hamilton/STAR.py @@ -7774,7 +7774,7 @@ async def pierce_foil( ) async def step_off_foil( - self, well: Well, front_channel: int, back_channel: int, move_inwards: float = 2 + self, well: Well, front_channel: int, back_channel: int, move_inwards: float = 2, move_height: float = 15 ): """ Hold down a plate by placing two channels on the edges of a plate that is sealed with foil @@ -7800,6 +7800,7 @@ async def step_off_foil( front_channel: The channel to place on the front of the plate. back_channel: The channel to place on the back of the plate. move_inwards: mm to move inwards (backward on the front channel; frontward on the back). + move_height: mm to move upwards after piercing the foil. front_channel and back_channel will hold the plate down. """ if front_channel <= back_channel: @@ -7828,7 +7829,7 @@ async def step_off_foil( zs = await self.get_channels_z_positions() indices = [channel_idx for channel_idx, z in zs.items() if z < front_location.z] idx = { - idx: front_location.z + 15 for idx in indices if idx not in (front_channel, back_channel) + idx: front_location.z + move_height for idx in indices if idx not in (front_channel, back_channel) } await self.position_channels_in_z_direction(idx) From c42ffa16025154f7e1f9a2ba53cdbc594bb2e768 Mon Sep 17 00:00:00 2001 From: Rick Wierenga Date: Thu, 13 Feb 2025 11:51:55 -0800 Subject: [PATCH 3/3] format --- pylabrobot/liquid_handling/backends/hamilton/STAR.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/pylabrobot/liquid_handling/backends/hamilton/STAR.py b/pylabrobot/liquid_handling/backends/hamilton/STAR.py index 542beb9502..9a2ec96f97 100644 --- a/pylabrobot/liquid_handling/backends/hamilton/STAR.py +++ b/pylabrobot/liquid_handling/backends/hamilton/STAR.py @@ -7774,7 +7774,12 @@ async def pierce_foil( ) async def step_off_foil( - self, well: Well, front_channel: int, back_channel: int, move_inwards: float = 2, move_height: float = 15 + self, + well: Well, + front_channel: int, + back_channel: int, + move_inwards: float = 2, + move_height: float = 15, ): """ Hold down a plate by placing two channels on the edges of a plate that is sealed with foil @@ -7829,7 +7834,9 @@ async def step_off_foil( zs = await self.get_channels_z_positions() indices = [channel_idx for channel_idx, z in zs.items() if z < front_location.z] idx = { - idx: front_location.z + move_height for idx in indices if idx not in (front_channel, back_channel) + idx: front_location.z + move_height + for idx in indices + if idx not in (front_channel, back_channel) } await self.position_channels_in_z_direction(idx)