NFC: Apply suggestions from code review

Co-authored-by: John Siirola <[email protected]>

Author: blnicho

pyomo/core/plugins/transform/lp_dual.py

@@ -140,7 +140,7 @@ def _take_dual(self, model, std_form):
                     # really expected here, so maybe we just scream? Or we leave
                     # the constraint in the model as it is written...
                     raise ValueError(
-                        f"The primal model contains a constraint that that the "
+                        f"The primal model contains a constraint that the "
                         f"parameterization makes trivial: '{primal_cons.name}'"
                         f"\nPlease deactivate it or declare it on another Block "
                         f"before taking the dual."
@@ -172,6 +172,7 @@ def _take_dual(self, model, std_form):
 
             domain = primal.domain
             lb, ub = domain.bounds()
+            # Note: the following checks the domain for continuity and compactness:
             if not domain == RangeSet(*domain.bounds(), 0):
                 raise ValueError(
                     f"The domain of the primal variable '{primal.name}' "

pyomo/core/tests/unit/test_lp_dual.py

@@ -408,7 +408,7 @@ def test_parameterization_makes_constraint_trivial(self):
         lp_dual = TransformationFactory('core.lp_dual')
         with self.assertRaisesRegex(
             ValueError,
-            "The primal model contains a constraint that that the "
+            "The primal model contains a constraint that the "
             "parameterization makes trivial: 'budgetish'"
             "\nPlease deactivate it or declare it on another Block "
             "before taking the dual.",

pyomo/repn/plugins/parameterized_standard_form.py

@@ -274,7 +274,7 @@ def tocsr(self):
         # Fix the row index pointer by inserting 0 at the beginning. The
         # row_index_ptr currently holds pointers to 1 past the last element of
         # each row, which is really the starting index for the next
-        # row. Inserting the 0 (the starting index for the firsst column)
+        # row. Inserting the 0 (the starting index for the first column)
         # shifts everything by one column, "converting" the vector to the
         # starting indices of each row, and extending the vector length to
         # num_rows + 1 (as is expected by the CSR matrix).