Skip to content

Commit 76af499

Browse files
authored
Update changelog validation (#1388)
Every edit to the changelog must be validated so that an invalid changelog doesn't block a release.
1 parent 99425b4 commit 76af499

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

.github/workflows/changelog.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ on:
55
branches:
66
- '**'
77
path:
8-
# Only run if changes were made in markdown/
8+
# Only run if changes were made in markdown/ or the changelog
99
- 'markdown/**'
10+
- 'docs/changelog.md'
1011

1112
# permissions:
1213
# pull-requests: write
@@ -16,12 +17,20 @@ jobs:
1617

1718
runs-on: ubuntu-latest
1819
steps:
19-
# - uses: actions/checkout@v2
20-
- uses: dangoslen/changelog-enforcer@v3
20+
- uses: actions/checkout@v2
21+
- name: Ensure Changelog Entry Made
22+
uses: dangoslen/changelog-enforcer@v3
2123
with:
2224
changeLogPath: 'docs/changelog.md'
2325
missingUpdateErrorMessage: |
2426
@${{ github.actor }}, thank you for your contribution. It appears that you have not added a comment to the
2527
changelog describing the changes you have made. Doing so will help to ensure your contribution is accepted.
2628
2729
Please see the [Contributing Guide](https://python-markdown.github.io/contributing/#changelog) for details.
30+
- name: Validate Changelog
31+
if: success()
32+
id: changelog_reader
33+
uses: mindsers/changelog-reader-action@v2
34+
with:
35+
validation_level: error
36+
path: docs/changelog.md

.github/workflows/deploy.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ jobs:
3232
id: changelog_reader
3333
uses: mindsers/changelog-reader-action@v2
3434
with:
35-
validation_level: warn
3635
version: ${{ github.ref_name }}
3736
path: ./docs/changelog.md
3837
- name: Release to GitHub

docs/changelog.md

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,21 +58,16 @@ links to the header, placing them after all other header content.
5858

5959
## [3.4.2] -- 2023-03-22
6060

61-
### Added
62-
63-
* Officially support Python 3.11.
64-
6561
### Fixed
66-
62+
* Officially support Python 3.11.
6763
* Improve standalone * and _ parsing (#1300).
6864
* Consider `<html>` HTML tag a block-level element (#1309).
69-
70-
### Infrastructure
71-
7265
* Switch from `setup.py` to `pyproject.toml`.
7366

7467
## [3.4.1] -- 2022-07-15
7568

69+
### Fixed
70+
7671
* Fix an import issue with `importlib.util` (#1274).
7772

7873
## [3.4] -- 2022-07-15
@@ -194,10 +189,6 @@ valid parameter and will raise an error if provided.
194189

195190
## [3.3.5] -- 2021-11-16
196191

197-
### Added
198-
199-
* Support Python 3.10 (#1124).
200-
201192
### Fixed
202193

203194
* Make the `slugify_unicode` function not remove diacritical marks (#1118).
@@ -206,6 +197,7 @@ valid parameter and will raise an error if provided.
206197
* Don't process shebangs in fenced code blocks when using CodeHilite (#1156).
207198
* Improve email address validation for Automatic Links (#1165).
208199
* Ensure `<summary>` tags are parsed correctly (#1079).
200+
* Support Python 3.10 (#1124).
209201

210202
## [3.3.4] -- 2021-02-24
211203

0 commit comments

Comments
 (0)