Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: rocthrust tag building against develop branch of rocprim #527

Open
StewMH opened this issue Mar 6, 2025 · 0 comments
Open

[Issue]: rocthrust tag building against develop branch of rocprim #527

StewMH opened this issue Mar 6, 2025 · 0 comments

Comments

@StewMH
Copy link

StewMH commented Mar 6, 2025

Problem Description

I have a compilation error when building rocthrust version 6.1.1:

/bld/_deps/rocthrust-build/deps/rocprim/include/rocprim/device/detail/config_types.hpp:324:78: error: use of undeclared identifier 'hipStreamLegacy'
  324 |     if(stream == default_stream || stream == hipStreamPerThread || stream == hipStreamLegacy)

I think the root cause is that rocThrust is picking up origin/develop instead of a fixed tag:
https://github.com/ROCm/rocThrust/blob/rocm-6.1.1/cmake/Dependencies.cmake

if(NOT rocprim_FOUND)
  message(STATUS "Downloading and building rocprim.")
  download_project(
    PROJ                rocprim
    GIT_REPOSITORY      https://github.com/ROCmSoftwarePlatform/rocPRIM.git
    GIT_TAG             develop

The same code is present in develop. Some CMake logic to select the matching release would make sense I think?

Operating System

Ubuntu 24.04

CPU

Apple M1 (virtualising amd64)

GPU

No GPU present (Docker container on a Mac), just compiling HIP

ROCm Version

ROCm 6.1.1

ROCm Component

rocThrust

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant