Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CMocka Linking Issues #48

Closed
bonedaddy opened this issue Aug 4, 2020 · 0 comments · Fixed by #50
Closed

Resolve CMocka Linking Issues #48

bonedaddy opened this issue Aug 4, 2020 · 0 comments · Fixed by #50

Comments

@bonedaddy
Copy link
Contributor

bonedaddy commented Aug 4, 2020

Right now because all test source files are bundled with the source files building the libraries ends up including cmocka dependencies. The proper solution will be to place the test files in a tests directory that way they wont be including when we build the individual libraries. Also for example the peerstore libraries the main libpeerstore target requires linking to the testutils library for the same reason.

This isn't super important right now, but should definitely be done for the MVP release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant