Wrong patch recommended for compiling on OpenWrt

[ilario]

Originally reported here javierbrk/vwifi_cli_package#1 (comment)

The patch recommended here https://github.com/Raizo62/vwifi/wiki/Install-on-OpenWRT-X86_64#download-the-code-of-vwifi

sed -i 's$1, NULL, 0,$1, 0, 0, 0, 0,$' ${HOME}/OpenWRT/vwifi/src/cmonwirelessdevice.cc

breaks the compilation causing this error:

build_dir/target-mipsel_24kc_musl/vwifi-1.0.0/src/cmonwirelessdevice.cc:210:94: error: too many initializers for 'msghdr'
  210 |         struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, 0, 0, 0, 0, 0 };

This happens because the sed command increases the number of arguments from

struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, NULL, 0, 0 };

to

struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, 0, 0, 0, 0, 0 };

[Raizo62]

Hi

I just re-attempted the compilation following the instructions on the Wiki from a Debian Trixie environment using OpenWRT 24.10.3 and everything worked fine; I didn't receive any error messages.

To help me reproduce the issue, could you please specify the details of your compilation environment? What Operating System (OS)
are you running?

[ilario]

Hi!
I checked again, I am on WSL (virtualized Ubuntu inside Windows, sorry for that), OpenWrt 24.05 and using the system libnl (with the compiled one I get errors).
The cmake command that works for me is simply cmake .., otherwise explosions.

So then, after applying the patch with sed, running cmake and running make I get:

root@PTILARIO:/home/user/OpenWRT/vwifi/build# cmake ..
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building version: 7.0 (Not a Git repo or git error)
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Checking for modules 'libnl-genl-3.0;libnl-3.0'
--   Found libnl-genl-3.0, version 3.5.0
--   Found libnl-3.0, version 3.5.0
-- Configuring done
-- Generating done
-- Build files have been written to: /home/user/OpenWRT/vwifi/build
root@PTILARIO:/home/user/OpenWRT/vwifi/build# make
[  2%] Building CXX object CMakeFiles/vwifi_common.dir/src/ccoordinate.cc.o
[  5%] Building CXX object CMakeFiles/vwifi_common.dir/src/cctrlserver.cc.o
[  8%] Building CXX object CMakeFiles/vwifi_common.dir/src/cdynbuffer.cc.o
[ 11%] Building CXX object CMakeFiles/vwifi_common.dir/src/cinfosocket.cc.o
[ 14%] Building CXX object CMakeFiles/vwifi_common.dir/src/cinfowifi.cc.o
[ 17%] Building CXX object CMakeFiles/vwifi_common.dir/src/ckernelwifi.cc.o
[ 20%] Building CXX object CMakeFiles/vwifi_common.dir/src/cmonwirelessdevice.cc.o
/home/user/OpenWRT/vwifi/src/cmonwirelessdevice.cc: In member function ‘void MonitorWirelessDevice::recv_inet_event()’:
/home/user/OpenWRT/vwifi/src/cmonwirelessdevice.cc:210:94: error: too many initializers for ‘msghdr’
  210 |         struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, 0, 0, 0, 0, 0 };
      |                                                                                              ^
make[2]: *** [CMakeFiles/vwifi_common.dir/build.make:160: CMakeFiles/vwifi_common.dir/src/cmonwirelessdevice.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:91: CMakeFiles/vwifi_common.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I think that the error makes sense, as the sed command adds two extra arguments:

210c210
<       struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, NULL, 0, 0 };
---
>       struct msghdr msg = { static_cast<void *>(&snl), sizeof(snl), &iov, 1, 0, 0, 0, 0, 0 };

The msghdr defined in sys/socket.h accepts 7 arguments, not 9.

Also, this line taken from the wiki is not changing the config.h file:
sed -i 's$^#define ENABLE_VHOST$//#define ENABLE_VHOST$g' ${HOME}/OpenWRT/vwifi/src/config.h

[Raizo62]

-- Checking for modules 'libnl-genl-3.0;libnl-3.0'
-- Found libnl-genl-3.0, version 3.5.0
-- Found libnl-3.0, version 3.5.0

Your libnl version is 3.5.0, but the last release of libnl is 3.11.0 ( wget https://github.com/thom311/libnl/releases/download/libnl3_11_0/libnl-3.11.0.tar.gz )

Also, this line taken from the wiki is not changing the config.h file:
sed -i 's$^#define ENABLE_VHOST$//#define ENABLE_VHOST$g' ${HOME}/OpenWRT/vwifi/src/config.h

You are right. Now we need to use cmake .. -DENABLE_VHOST=OFF
I've updated the wiki. Thanks.

[ilario]

-- Checking for modules 'libnl-genl-3.0;libnl-3.0'
-- Found libnl-genl-3.0, version 3.5.0
-- Found libnl-3.0, version 3.5.0

Your libnl version is 3.5.0, but the last release of libnl is 3.11.0 ( wget https://github.com/thom311/libnl/releases/download/libnl3_11_0/libnl-3.11.0.tar.gz )

This should be irrelevant but I will try to use 3.11.

[Raizo62]

It's still strange. It's cross-compiling. With the same files, we should have the same result. So, what are you doing that gives this different result ?