Skip to content

Commit 3c85e38

Browse files
committed
Fixed mishandling of negative oid refs
1 parent 3850619 commit 3c85e38

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/com/rallydev/rest/util/Ref.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class Ref {
2020
Pattern.compile(".*?/(\\w{2,}/\\w+)/(\\d+)(?:\\.js\\??.*)*$"),
2121

2222
//collection ref (/defect/1234/tasks)
23-
Pattern.compile(".*?/(\\w+/\\d+)/(\\w+)(?:\\.js\\??.*)*$"),
23+
Pattern.compile(".*?/(\\w+/-?\\d+)/(\\w+)(?:\\.js\\??.*)*$"),
2424

2525
//basic ref (/defect/1234)
2626
Pattern.compile(".*?/(\\w+)/(\\d+)(?:\\.js\\??.*)*$"),

test/com/rallydev/rest/util/RefTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,6 @@ public void shouldSupportCollectionRefs() {
118118
Assert.assertEquals(Ref.getRelativeRef("/defect/1234/tasks"), "/defect/1234/tasks", "Valid relative collection ref");
119119
Assert.assertEquals(Ref.getRelativeRef("https://rally1.rallydev.com/slm/webservice/1.38/portfolioitem/feature/1234/children"), "/portfolioitem/feature/1234/children", "Valid dynatype collection ref");
120120
Assert.assertEquals(Ref.getRelativeRef("/portfolioitem/feature/1234/children"), "/portfolioitem/feature/1234/children", "Valid dynatype relative collection ref");
121+
Assert.assertEquals(Ref.getRelativeRef("/typedefinition/-12345/attributes"), "/typedefinition/-12345/attributes", "Valid built-in type def attributes relative collection ref");
121122
}
122123
}

0 commit comments

Comments
 (0)