Skip to content

Ensure updateAndSetOwner() updates Placement resource only once as well as DRPC #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BenamarMk opened this issue Sep 13, 2023 · 1 comment · May be fixed by #1874
Open

Ensure updateAndSetOwner() updates Placement resource only once as well as DRPC #1066

BenamarMk opened this issue Sep 13, 2023 · 1 comment · May be fixed by #1874
Assignees
@BenamarMk

Comments

@BenamarMk
Copy link
Member

The DRPC function updateAndSetOwner() calls the client Update() function multiple times within the same reconciliation. This causes resource version conflict and delays of the reconciliation execution.

A potential solution is to update the Placement and DRPC only once if possible. In other words;

  1. Placement: Call Update() after annotation and finalizer are added
  2. DRPC: Call Update() after finalizer and DRPC owner are added.

This issue is in response to this comment
@rakeshgm rakeshgm self-assigned this Sep 15, 2023
@BenamarMk BenamarMk assigned BenamarMk and unassigned rakeshgm Feb 24, 2025
@OdedViner
Copy link
Contributor

I am working on this issue

@OdedViner OdedViner linked a pull request Mar 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenamarMk BenamarMk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize updateAndSetOwner to Reduce Multiple Updates and Prevent Conflicts OdedViner/ramen
3 participants
@rakeshgm @BenamarMk @OdedViner