From 40e802750aa44fce9e189fd11183cf064dfd624e Mon Sep 17 00:00:00 2001
From: badasahog <52379863+badasahog@users.noreply.github.com>
Date: Wed, 17 Sep 2025 07:14:44 -0400
Subject: [PATCH 1/2] switch to snake case + minor spelling correction

---
 src/fread.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/fread.c b/src/fread.c
index 8f905e5e2..1dd979655 100644
--- a/src/fread.c
+++ b/src/fread.c
@@ -47,7 +47,7 @@ enum quote_rule_t
     // Fields may be quoted, but any quotes inside will appear verbatim and
     // not escaped in any way. It is not always possible to parse the file
     // unambiguously, but we give it a try anyways. A quote will be presumed
-    // to mark the end of the field iff it is followed by the field separator.
+    // to mark the end of the field if it is followed by the field separator.
     // Under this rule eol characters cannot appear inside the field.
     // For example: <<...,"hello "world"",...>>
     QUOTE_RULE_EMBEDDED_QUOTES_NOT_ESCAPED,
@@ -292,7 +292,7 @@ static inline bool eol(const char **pch)
 }
 
 /**
- * Return True iff `ch` is a valid field terminator character: either a field
+ * Return True if `ch` is a valid field terminator character: either a field
  * separator or a newline.
  */
 static inline bool end_of_field(const char *ch)
@@ -453,15 +453,15 @@ static const char* filesize_to_str(const uint64_t fsize)
   return output;
 }
 
-double copyFile(size_t fileSize)  // only called in very very rare cases
+double copy_file(size_t file_size)  // only called in very very rare cases
 {
   double tt = wallclock();
-  mmp_copy = malloc(fileSize + 1 /* extra \0 */);
+  mmp_copy = malloc(file_size + 1 /* extra \0 */);
   if (!mmp_copy)
     return -1.0; // # nocov
-  memcpy(mmp_copy, mmp, fileSize);
+  memcpy(mmp_copy, mmp, file_size);
   sof = mmp_copy;
-  eof = (char*)OFFSET_POINTER(mmp_copy, fileSize);
+  eof = (char*)OFFSET_POINTER(mmp_copy, file_size);
   return wallclock() - tt;
 }
 
@@ -1603,7 +1603,7 @@ int freadMain(freadMainArgs _args)
         if (verbose)
           DTPRINT(_("  File ends abruptly with '%c'. Final end-of-line is missing. Copying file in RAM. %s.\n"), eof[-1], msg);
         // In future, we may discover a way to mmap fileSize+1 on all OS when fileSize%4096==0, reliably. If and when, this clause can be updated with no code impact elsewhere.
-        double time_taken = copyFile(fileSize);
+        double time_taken = copy_file(fileSize);
         if (time_taken == -1.0) {
           // # nocov start
           if (!verbose)
@@ -1892,7 +1892,7 @@ int freadMain(freadMainArgs _args)
         if (verbose)
           DTPRINT(_("  Copying file in RAM. %s\n"), msg);
         ASSERT(mmp_copy == NULL, "mmp has already been copied due to abrupt non-eol ending, so it does not end with 2 or more eol.%s", ""/*dummy arg for macro*/); // #nocov
-        double time_taken = copyFile(fileSize);
+        double time_taken = copy_file(fileSize);
         if (time_taken == -1.0) {
           // # nocov start
           if (!verbose)
@@ -1929,7 +1929,7 @@ int freadMain(freadMainArgs _args)
   if (verbose) DTPRINT(_("[07] Detect column types, dec, good nrow estimate and whether first row is column names\n"));
   if (verbose && args.header != NA_BOOL8) DTPRINT(_("  'header' changed by user from 'auto' to %s\n"), args.header ? "true" : "false");
 
-  type =    malloc(sizeof(*type) * ncol);
+  type = malloc(sizeof(*type) * ncol);
   tmpType = malloc(sizeof(*tmpType) * ncol);  // used i) in sampling to not stop on errors when bad jump point and ii) when accepting user overrides
   if (!type || !tmpType) {
     free(type); free(tmpType); // # nocov

From d0dac8ebd53901a633b221409a6c6b2640d2eace Mon Sep 17 00:00:00 2001
From: badasahog <52379863+badasahog@users.noreply.github.com>
Date: Wed, 17 Sep 2025 07:50:20 -0400
Subject: [PATCH 2/2] reverting to iff

---
 src/fread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/fread.c b/src/fread.c
index 1dd979655..0f1548ac3 100644
--- a/src/fread.c
+++ b/src/fread.c
@@ -47,7 +47,7 @@ enum quote_rule_t
     // Fields may be quoted, but any quotes inside will appear verbatim and
     // not escaped in any way. It is not always possible to parse the file
     // unambiguously, but we give it a try anyways. A quote will be presumed
-    // to mark the end of the field if it is followed by the field separator.
+    // to mark the end of the field iff it is followed by the field separator.
     // Under this rule eol characters cannot appear inside the field.
     // For example: <<...,"hello "world"",...>>
     QUOTE_RULE_EMBEDDED_QUOTES_NOT_ESCAPED,
@@ -292,7 +292,7 @@ static inline bool eol(const char **pch)
 }
 
 /**
- * Return True if `ch` is a valid field terminator character: either a field
+ * Return True iff `ch` is a valid field terminator character: either a field
  * separator or a newline.
  */
 static inline bool end_of_field(const char *ch)