fix: Use ReVanced background colour for splash screen #2635
Conversation
These never did anything and were removed from the figma a while ago.
I can't believe this happened
Co-authored-by: Ax333l <[email protected]>
|
Can this be merged? Should the splash art be used with a background instead? |
On second thoughts, I like the idea of having a splash art use with a background. cc: reviewers @Axelen123 do you have any objections? |
|
I don't have any objections to that |
|
@validcube do you have any update on this? Would be cool to merge this before release, if possible. |
|
Around third week of september when I will be fully available, but because
this PR(or [s] others) has been up for a long time I could immediately try
to fit in a slot for revanced around tomorrow evening and hopefully finish
* #2635, #2637, #2699
ในวันที่ จ. 25 ส.ค. 2025 เวลา 20:42 brosssh ***@***.***>
เขียนว่า:
… *brosssh* left a comment (ReVanced/revanced-manager#2635)
<#2635 (comment)>
@validcube <https://github.com/validcube> do you have any update on this?
Would be cool to merge this before release, if possible.
—
Reply to this email directly, view it on GitHub
<#2635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGPSOC5NHAZDHJJ6TKAZB33PMHFFAVCNFSM6AAAAACA3A5YJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRQGMZTQOJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Additionally, that being said, if you need it now, lmk, because I can
squeeze only this PR in my time slot.
ในวันที่ จ. 25 ส.ค. 2025 เวลา 22:06 Pun ***@***.***> เขียนว่า:
… Around third week of september when I will be fully available, but because
this PR(or [s] others) has been up for a long time I could immediately try
to fit in a slot for revanced around tomorrow evening and hopefully finish
* #2635, #2637, #2699
ในวันที่ จ. 25 ส.ค. 2025 เวลา 20:42 brosssh ***@***.***>
เขียนว่า:
> *brosssh* left a comment (ReVanced/revanced-manager#2635)
> <#2635 (comment)>
>
> @validcube <https://github.com/validcube> do you have any update on
> this? Would be cool to merge this before release, if possible.
>
> —
> Reply to this email directly, view it on GitHub
> <#2635 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWGPSOC5NHAZDHJJ6TKAZB33PMHFFAVCNFSM6AAAAACA3A5YJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRQGMZTQOJUGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
validcube
changed the title
|
Preview
|
|
The logo looks kinda small in my opinion, wdyt @validcube? |
Honestly, I don't think I can do anything about it. Logo has to fit within the spec provided by androidx splash screen https://developer.android.com/reference/kotlin/androidx/core/splashscreen/SplashScreen#specs Which is honestly, small to work with. |
|
What do you mean "bigger"? Is there a standard? |
|
It's my personal opinion, as stated in my previous comment. If I compare it with other apps (GitHub, Discord, Spotify..) it looks smaller. |
|
No, splash screens have guidelines: https://developer.android.com/develop/ui/views/launch/splash-screen |
Could the size different be related to the background then? 
|
|
Superceded |
Fix one of the problem on #1191 about ReVanced logo (V-shape) is hardly seen in light mode.