Merge pull request #852 from ReactTooltip/fix-position-content-race-condition

danielbarion · web-flow · commit 1f4594adedc9 · 2022-12-12T18:25:30.000-03:00
fix: recalculate tooltip position on content change
diff --git a/src/components/Tooltip/Tooltip.tsx b/src/components/Tooltip/Tooltip.tsx
@@ -189,7 +189,7 @@ const Tooltip = ({
     return () => {
       mounted = false
     }
-  }, [show, isOpen, anchorId, activeAnchor, place, offset, positionStrategy])
+  }, [show, isOpen, anchorId, activeAnchor, content, place, offset, positionStrategy])
 
   useEffect(() => {
     return () => {

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ const Tooltip = ({`
`189`	`189`	`return () => {`
`190`	`190`	`mounted = false`
`191`	`191`	`}`
`192`		`- }, [show, isOpen, anchorId, activeAnchor, place, offset, positionStrategy])`
	`192`	`+ }, [show, isOpen, anchorId, activeAnchor, content, place, offset, positionStrategy])`
`193`	`193`
`194`	`194`	`useEffect(() => {`
`195`	`195`	`return () => {`