Skip to content

Commit e82b082

Browse files
committed
Fixed A-factor correction for SurfaceChargeTransfer
Added solvent correction for SurfaceChargeTransfer
1 parent b5c37c4 commit e82b082

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

rmgpy/reaction.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ def fix_barrier_height(self, force_positive=False, solvent="", apply_solvation_c
996996

997997
if self.kinetics is None:
998998
raise KineticsError("Cannot fix barrier height for reactions with no kinetics attribute")
999-
999+
10001000
if isinstance(self.kinetics, Marcus):
10011001
if apply_solvation_correction and solvent:
10021002
self.apply_solvent_correction(solvent)
@@ -1039,7 +1039,7 @@ def fix_barrier_height(self, force_positive=False, solvent="", apply_solvation_c
10391039
logging.info("For reaction {0!s} Ea raised from {1:.1f} to {2:.1f} kJ/mol.".format(
10401040
self, self.kinetics.Ea.value_si / 1000., Ea / 1000.))
10411041
self.kinetics.Ea.value_si = Ea
1042-
if isinstance(self.kinetics, (Arrhenius, StickingCoefficient, ArrheniusChargeTransfer)): # SurfaceArrhenius is a subclass of Arrhenius
1042+
if isinstance(self.kinetics, (Arrhenius, StickingCoefficient, ArrheniusChargeTransfer, SurfaceChargeTransfer)): # SurfaceArrhenius is a subclass of Arrhenius
10431043
if apply_solvation_correction and solvent and self.kinetics.solute:
10441044
self.apply_solvent_correction(solvent)
10451045
Ea = self.kinetics.Ea.value_si

rmgpy/rmg/reactors.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -601,22 +601,20 @@ def to_rms(obj, species_names=None, rms_species_list=None, rmg_species=None):
601601
A = obj._A.value_si
602602
if obj._T0.value_si != 1.0:
603603
A /= ((obj._T0.value_si) ** obj._n.value_si)
604-
# if obj._V0.value_si != 0.0:
605-
# A *= np.exp(obj._alpha.value_si*obj._electrons.value_si*constants.F*obj.V0.value_si/constants.R/300)
606604
n = obj._n.value_si
607605
Ea = obj._Ea.value_si
608-
q = obj._alpha.value_si*obj._electrons.value_si
609-
return rms.Arrheniusq(A, n, Ea, q, rms.EmptyRateUncertainty())
606+
q = obj._alpha.value_si*obj._electrons.value_si
607+
V0 = obj._V0.value_si
608+
return rms.Arrheniusq(A, n, Ea, q, V0, rms.EmptyRateUncertainty())
610609
elif isinstance(obj, SurfaceChargeTransfer):
611610
A = obj._A.value_si
612611
if obj._T0.value_si != 1.0:
613612
A /= ((obj._T0.value_si) ** obj._n.value_si)
614-
# if obj._V0.value_si != 0.0:
615-
# A *= np.exp(obj._alpha.value_si*obj._electrons.value_si*constants.F*obj.V0.value_si/constants.R/300)
616613
n = obj._n.value_si
617614
Ea = obj._Ea.value_si
618615
q = obj._alpha.value_si*obj._electrons.value_si
619-
return rms.Arrheniusq(A, n, Ea, q, rms.EmptyRateUncertainty())
616+
V0 = obj._V0.value_si
617+
return rms.Arrheniusq(A, n, Ea, q, V0, rms.EmptyRateUncertainty())
620618
elif isinstance(obj, Marcus):
621619
A = obj._A.value_si
622620
n = obj._n.value_si
@@ -725,7 +723,7 @@ def to_rms(obj, species_names=None, rms_species_list=None, rmg_species=None):
725723
else:
726724
atomnums[atm.element.symbol] = 1
727725
bondnum = len(mol.get_all_edges())
728-
726+
729727
if not obj.molecule[0].contains_surface_site():
730728
rad = rms.getspeciesradius(atomnums, bondnum)
731729
diff = rms.StokesDiffusivity(rad)

0 commit comments

Comments
 (0)