-
Notifications
You must be signed in to change notification settings - Fork 249
Update RMG developer install instruction #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e563257 to
96c8830
Compare
|
Please can you put reasons for changes into the commit messages? |
Codecov Report
@@ Coverage Diff @@
## main #2524 +/- ##
=======================================
Coverage 49.88% 49.88%
=======================================
Files 125 125
Lines 37139 37139
=======================================
Hits 18526 18526
Misses 18613 18613 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment was marked as outdated.
This comment was marked as outdated.
|
This CI run that on this PR that just failed used I just created a new environment on my (Intel) Mac (with a new miniconda) and it worked fine with the libmamba solver, and with |
|
Thanks for the comment. I will rebase and update the commit msg. Regarding the Julia version and the solver backend. Yesterday I did a clean installation of RMG on an ubuntu 23.04 machine following the current instruction. However, using the libmamba solver in the Julia step will cause the installation to stall. I got an error msg saying things like "conda freeze when solving the environment, retrying with classic solver". However, the installation will just stay stalled and won't continue. When I switched to Julia 1.8.5 and used the classic solver, the installation worked fine. I can try to do another fresh installation of RMG on an ubuntu machine to see if the issue persists. |
|
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days. |
|
The issues with Julia 1.9.2 seem to be resolved (see this successful CI run using that version), as well as the installation with |
Motivation or Problem
Run into several problems when doing a clean installation of RMG from source following the instructions recently. Turns out the guidance needs to be updated.
Description of Changes
set julia version to be 1.8.5, the latest version verified to work with current RMG. Newer julia versions such as 1.9.2 cause issues during compiling.
change the conda backend to classic/default before calling julia command; otherwise compilation won't complete.
update julia command so the package installation won't freeze.
Testing
Did a clean installation with the updated instruction. Ran RMG and Arkane minimal tests and they both work.
Reviewer Tips
Can try a clean installation to verify the changes.