Marcus development #267
Open
Marcus development #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paper is published. It's open access so I figured no need to keep the preprint link.
ssun30
force-pushed
the
marcus_development
branch
from
b582e25 to
c1c7965
Compare
Removed an invalid field in a Marcus type reaction in ORR.rms
`cat` is a default Julia function for concatenating arrays. As a precaution these are renamed to `catalyst` to avoid conflicts
ssun30
force-pushed
the
marcus_development
branch
from
c1c7965 to
526fa90
Compare
this interface creates diffusive fluxes between a given domain and a constant concentration reservoir Some bugfixes by Su: Fixed undefined variable S Added missing "export" for ConstantReservoirDiffusion Co-authored-by: Matt Johnson <[email protected]> Co-authored-by: Su Sun <[email protected]>
fixup: fix assignment to dot addition .+=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #247 .
The original PR has been modified to include commits that adapts RMS to the new Python-Julia interface. As such it could not be deployed before those changes are deployed. This branch includes all the necessary commits to handle Marcus and Surface Arrhenius kinetics.