Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to compile code when using zip (was able to compile using version 2.3.0) #397

Open
nikobarli opened this issue Sep 7, 2017 · 1 comment
Labels

Comments

@nikobarli
Copy link

The following code cannot be compiled in v4.0. It was compilable in version 2.3.0. I am not sure if it is intended or not.

auto ZipAndAdd(const rxcpp::observable<int> & in1, const rxcpp::observable<int> & in2) {
    return in1.zip(in2);
}

It gave errors as follows:

rx-observable.hpp(1123): error C2672: 'observable_member': no matching overloaded function found

Removing the const on the second argument declaration fixed this error.

@nikobarli nikobarli changed the title not compiling code when using zip (was able to compile using version 2.3.0) not able to compile code when using zip (was able to compile using version 2.3.0) Sep 7, 2017
@kirkshoop kirkshoop added the bug label Sep 7, 2017
@kirkshoop
Copy link
Member

Thanks you for the report!

this is not expected. the major version changes were due to a large change in how the operators were defined.

This should be fairly easy to fix in struct member_overload<zip_tag>. except I cannot see any obvious mistake..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants