-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Description
Issue Description
Two endorsement-related endpoints (GET and POST) are currently defined under the skills controller, which should be in endorsement controller. These routes should be moved under /v1/endorsements to maintain clear and consistent resource boundaries.
Current Behavior
-
The API exposes two endorsement-related endpoints under the
skillsresource:GET /v1/skills/{id}/endorsementsPOST /v1/skills/{id}/endorsements
-
This design implies that endorsements are strictly tied to the
skillsresource. But a separate routePATCH /v1/endorsements/{id}already exists under theendorsementsresource. This causes inconsistency in routing structure.
Expected Behavior
- All endorsement-related actions should be grouped under
/v1/endorsements. - Specifically,
GET /v1/skills/{id}/endorsementsandPOST /v1/skills/{id}/endorsements.
Steps to Reproduce
- Look at the current route definitions in the skill controller.
- Notice endorsement-related logic defined under the skills controller.
- Compare this with
PATCH /v1/endorsements/{id}, which is defined under the endorsement controller.
Screenshots
Severity/Priority
- Critical
- High
- Medium
- Low
Checklist
- I have read and followed the project's code of conduct.
- I have searched for similar issues before creating this one.
- I have provided all the necessary information to understand and reproduce the issue.
- I am willing to contribute to the resolution of this issue.
Metadata
Metadata
Assignees
Labels
No labels