Extension requests#284
Merged
ankushdharkar merged 16 commits intoRealDevSquad:developfrom Apr 27, 2023
Merged
Conversation
sahsisunny
reviewed
Jan 16, 2023
ivinayakg
commented
Jan 21, 2023
bajajcodes
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
sahsisunny
reviewed
Feb 2, 2023
Contributor
There was a problem hiding this comment.
Some suggestions
- Please use
reminstead ofpx. - Also removed the
comments(if not necessary) querySelectorAllnot good for selectingid- Create a single function that can be used to show the error message whenever needed.
Note : Others looks good from my side as far as i understand
ankushdharkar
added
the
feature task
heyrandhir
suggested changes
Feb 28, 2023
Contributor
heyrandhir
left a comment
heyrandhir
left a comment
There was a problem hiding this comment.
can we have the tests as well.
heyrandhir
previously approved these changes
Mar 17, 2023
heyrandhir
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
SUPERUSERonly.APPROVED), which will by default change the new ETA of the task if the status is updated toAPPROVED.UI