Minor bug fixes

Author: Nicholas Smith

src/providers/JiraTicketProvider.ts

@@ -165,9 +165,9 @@ export class JiraTicketProvider implements TicketProviderInterface {
     const summary = `[${errorGroup.type}] ${errorGroup.name}`;
 
     let description = errorGroup.name +
-      '\n\nh3.Frequency' +
+      '\nh3.Frequency\n' +
       `${errorGroup.count} ${errorGroup.countType} per day` +
-      '\n\nh3.Instances';
+      '\nh3.Instances\n';
 
     for (const instance of errorGroup.instances.slice(0, maxInstances)) {
       description += `${instance.name}\n\nTroubleshoot at: [${instance.debugUrl}]`;
@@ -183,7 +183,12 @@ export class JiraTicketProvider implements TicketProviderInterface {
       summary,
       description,
       priority: this.config.ticket.priorityMap[errorGroup.priority],
-      labels: ['error_sync', `error:${errorGroup.clientId}`],
+      labels: [
+        'error_sync',
+        `error:${errorGroup.clientId}`,
+        errorGroup.sourceName,
+        errorGroup.type,
+      ],
     }
   }
 

src/providers/OpsGenieAlertProvider.ts

@@ -33,10 +33,18 @@ export class OpsGenieAlertProvider implements AlertProviderInterface {
   public async findAlert(clientId: string): Promise<Alert> {
     const opsgenieAlert: any = await new Promise((resolve, reject) => {
       opsGenie.alertV2.get({
-        identifier: clientId,
+        identifier: clientId + 'fake',
         identifierType: 'alias',
       }, (error, response) => {
-        return (error ? reject(error) : resolve(response.data));
+        if (!error) {
+          return resolve(response.data);
+        } else if (error.httpStatusCode === 404) {
+          return undefined;
+        } else if (error instanceof Error) {
+          throw error;
+        } else {
+          throw new Error(error.message || error);
+        }
       });
     });