Skip to content
This repository was archived by the owner on Oct 21, 2019. It is now read-only.
This repository was archived by the owner on Oct 21, 2019. It is now read-only.

Allow setting PREFIX at build time #19

@ersinakinci

Description

@ersinakinci

First of all, thanks so much for putting this together. GDAL is a pain to compile.

I'm using your images with https://github.com/UnitedIncome/serverless-python-requirements to get GDAL working on AWS Lambda. Unfortunately, there's a conflict because both this project's Dockerfile and serverless-python-requirements attempt to use /var/task in the container's file system, the former to install GDAL and the latter to mount a volume. The path is hardcoded in both cases.

Ideally, the mount path should be overridable in serverless-python-requirements. Until then, it wouldn't hurt to make the PREFIX, currently set by a hardcoded ENV in the Dockerfile, overridable at build time by using an ARG. I've created a PR that accomplishes precisely this: #18. The default is still set to /var/task, so it shouldn't break anything.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions