Skip to content
This repository has been archived by the owner on Mar 9, 2020. It is now read-only.

end_point is not incrementing within the functions #3

Open
danaldea opened this issue Sep 10, 2019 · 1 comment
Open

end_point is not incrementing within the functions #3

danaldea opened this issue Sep 10, 2019 · 1 comment

Comments

@danaldea
Copy link

Hey there,

First of all, great stuff, I've been trying to do this for a while now but hadn't thought to use the average outcome. Brilliant!

Issue: because you are importing the globals.py which imports the settings.py within the function calls (current_pattern, pattern_storage, pattern_recognition), you are using the initial endoints within the functions (you can see it prints the same real_outcome every time...).

In the main.py the end_point gets incremented correctly but unfortunately that value is not used by the functions. You can check by printing the end_point from the functions and see for yourself.

Me because I'm no python master, I've just chosen the easy way around and initialized the end_point in the main.py and then pass it to the functions as a parameter rather then importing it from settings.py (and of course, removed end_point assignment from settings.py).

Cheers,
Dan

PS: running it now, seems to have the same overall accuracy with the change, will update when done running

@danaldea
Copy link
Author

Finished running: it still has very good results (85% vs 92% on a dataset of mine). Was a bit worried that the change will ruin everything :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant