Feature/add support for actions with arguments #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove logging messages used for debugging
lleon95
requested changes
Sep 4, 2025
|
|
||
| if (ret_sig != 0) { | ||
| ret = GSTD_BAD_VALUE; | ||
| /* The return value is not required */ |
Contributor
There was a problem hiding this comment.
You should document this. That the actions ignore the return values
Comment on lines
-314
to
-316
| if (query != NULL) { | ||
| name = g_hash_table_lookup (query, "name"); | ||
| description_pipe = g_hash_table_lookup (query, "description"); |
Contributor
There was a problem hiding this comment.
Have you evaluated if this breaks something? It seems that everything is now encapsulated into a JSON. I wonder if this is going to break something on the HTTP side. Have you checked the examples?
Author
There was a problem hiding this comment.
Yes, I evaluated the examples using Postman and curl, with the current HTTP structure and using a JSON. For example:
curl --location 'http://127.0.0.1:3000/pipelines' --header 'Content-Type: application/json' --data '{"name": "p1", "description": "videotestsrc name=vts ! identity name=id ! autovideosink"}'
curl --location --request POST 'http://127.0.0.1:3000/pipelines?name=p0&description=videotestsrc%20name%3Dvts%20!%20identity%20name%3Did%20!%20autovideosink'
DmongeN
force-pushed
the
feature/add-support-for-actions-with-arguments
branch
from
4c72c41 to
0084c4b
Compare
lleon95
requested changes
Dec 3, 2025
Comment on lines
+279
to
+280
| for (guint i = 0; i <= query.n_params; i++) | ||
| g_value_unset (&args[i]); |
Comment on lines
+395
to
+398
| if (!json_parser_load_from_data (parser, | ||
| msg->request_body->data, | ||
| msg->request_body->length, | ||
| &err)) { |
Contributor
There was a problem hiding this comment.
Indentation is incorrect. You should use gst-indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support action signals with one or more arguments.
Support adding
nameanddescriptionto HTTP PUT and POST requests in the request body asapplication/jsontype