Skip to content

Commit bf7f194

Browse files
committed
Removed some redundant Reflection*#setAccessible()` calls
These calls are no longer needed as per: * https://wiki.php.net/rfc/make-reflection-setaccessible-no-op * php/php-src#5412
1 parent 48a560f commit bf7f194

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

test/unit/Psalm/ConfigurationTest.php

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,8 @@ public function testConfigurationDefaults(): void
2525
$reflectionUseDocblockTypes = new ReflectionProperty(Configuration::class, 'use_docblock_types');
2626
$reflectionInstance = new ReflectionProperty(Config::class, 'instance');
2727
$reflectionIncludeCollector = new ReflectionProperty(Config::class, 'include_collector');
28-
29-
$reflectionFiles->setAccessible(true);
30-
$reflectionUseDocblockTypes->setAccessible(true);
31-
$reflectionInstance->setAccessible(true);
32-
$reflectionIncludeCollector->setAccessible(true);
33-
34-
$projectFiles = ProjectFileFilter::loadFromArray([], __DIR__, true);
35-
$configuration = Configuration::forStrictlyCheckedNamespacesAndProjectFiles($projectFiles);
28+
$projectFiles = ProjectFileFilter::loadFromArray([], __DIR__, true);
29+
$configuration = Configuration::forStrictlyCheckedNamespacesAndProjectFiles($projectFiles);
3630

3731
self::assertSame($projectFiles, $reflectionFiles->getValue($configuration));
3832
self::assertTrue($reflectionUseDocblockTypes->getValue($configuration));

test/unit/Psalm/ProjectFilesToBeTypeCheckedTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ public function testFilesToBeChecked(): void
3333

3434
$reflectionInclusive = new ReflectionProperty(ProjectFileFilter::class, 'inclusive');
3535

36-
$reflectionInclusive->setAccessible(true);
37-
3836
self::assertSame([realpath(__DIR__ . '/../Composer') . '/'], $files->getDirectories());
3937
self::assertSame([realpath(__FILE__)], $files->getFiles());
4038
self::assertTrue($reflectionInclusive->getValue($files));

0 commit comments

Comments
 (0)