Skip to content

Invalid impact provider implementation #62

@patryk3211

Description

@patryk3211

private static DoubleSupplier getImpact(Block block) {
if (!(block instanceof CGBacktankBlock)) return () -> 0;
return () -> BlockStressValues.getImpact(AllBlocks.COPPER_BACKTANK.get());
}

By returning 0 for any blocks that are not CGBacktankBlock you are going to break any other mod that registers a stress provider after yours. This is affected by mod load order and can cause a lot of frustration for mod pack makers. The correct implementation should return null to pass the control to other impact providers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions