-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-native-blob-util v0.17.0 crashes #197
Comments
What error do you get when your app crashes? |
Here is XCode StackTrace when the app starts on simulator:
|
IS the cras hhappening on start up or when you're calling a certain function? If the later, please provide a code snippet so I can try to reproduce it |
On start up |
It happens on startup |
I can't reproduce the problem in a new project. |
I can also see my app crashing after the 0.17.0 update. Had to revert back. |
@jinshin1013 which react-native version? Android or iOS? |
@cortinico sorry to bother you, do you have any idea what might be going on here? I can't reproduce it on my devices with a new project... |
In my case I get similar error on iOS
Something about
This might be an issue of using the const requestFiles = []
ReactNativeBlobUtil.fetch("POST", WEB_BASE_API_URL, headers, requestFiles).uploadProgress((written, total) => {
onUploadProgress({
loaded: written,
total
})
}) Versions tested: 0.16.4, 0.17.0 |
Thank you - but I think this is another issue. In 0.16.4 it works, in 0.17.0 it doesn't? So like we lost the check on the length |
I still can't reproduce your issue @keremoge. Any additional info on it? |
None of those two versions work, when passing empty array. |
Here is detailed error info:
|
can confirm, happens on iPhone 14Pro simulator and device, but weirdly not on iPhone14 simulator (no device at hand)
|
Same thing, downgrading to 0.16.4 works my env : xcode 14 |
Same also can't reproduce. |
This error is happening to us intermittently in production, but I also can't reproduce it locally. From investigating the stacktrace I have determined that the error is being thrown from this line:
I suspect that what's happening is that the view returned by
is somehow not actually of type |
I'm also having problems running 0.17.0 on react-native 0.70.6 using the new architecture. I'm building on an android platform and the app is crashing on start. The log error I get is different though:
Versions tested: 0.17.0 I did try it on an emulator running Android 11 and it worked. |
Same here, I just upgraded to 0.17.1 and the app crashed when I tried to read a file from FS Crash report
Offending line
|
Same here xCode 12.5.1
Any solutions? |
Same here, I am using 0.17.2 I am not sure how to reproduce this issue, but there is around 1% of our users are facing it immediately after startup |
same hare, using after upgraded to "react-native": "0.71.3","react-native-blob-util": "^0.17.0", |
@herarya @WadhahEssam @MCervenka @simon-abbott are you all using react-native-navigation? |
I use react-native-navigation |
We use |
v0.17.0, v0.17.2 still crash in iphone 14 pro model |
I managed to reproduce it now and created a repo for testing: https://github.com/RonRadtke/RNBlob_bug_rootview The issue seems to be that some libraries are exchanging the rootview with an own UIView and therefor I can't access the bridge via it anymore. |
Okay I think I should rework the whole EventEmitter logic to fix this so we are independant on the bridge and remove deprecated APIs in addition |
As mentioned, I plan on rewriting the whole Eventemitter part, so sending events form native to js. |
Hey @RonRadtke any update on this issue? I just upgraded to 0.18.3 and still happening. Will revert back to 0.16.4 for now. But would be great to be able to upgrade this lib in the future. |
What's the stack trace? |
@RonRadtke thanks for the quick reply, very much appreciated. same one as this #197 (comment) OS Version: iOS 16.5.1 (20F75) Exception Type: EXC_CRASH (SIGABRT) Application Specific Information: Thread 5 Crashed: Thread 0 Thread 1 Thread 2 Thread 3 name: com.apple.uikit.eventfetch-thread Thread 4 Thread 5 Crashed: Thread 6 Thread 7 Thread 8 name: com.facebook.react.JavaScript Thread 9 name: hades Thread 10 name: hermes-chrome-inspector-conn Thread 11 name: hermes-inspector Thread 12 Thread 13 name: com.apple.CoreMotion.MotionThread Thread 14 name: com.apple.NSURLConnectionLoader Thread 15 name: AXSpeech Thread 16 Thread 17 name: hades Thread 18 name: hermes-chrome-inspector-conn Thread 19 name: hermes-inspector Thread 20 Thread 21 name: SentryCrash Exception Handler (Secondary) Thread 22 name: SentryCrash Exception Handler (Primary) Thread 23 name: io.sentry.app-hang-tracker Thread 24 name: JavaScriptCore libpas scavenger EOF |
@walterholohan thank you. That's an issue not related to the event emitting. |
Thank you. I think its only for the encoding but will double check later. This is the only place in the app where we use library |
@RonRadtke |
@RonRadtke can we reopen please? As I just updated from 0.16.4 to 0.19.5 and got the same crash as above ![]() |
@walterholohan does it crash on 0.19.6 as well? |
Hey @RonRadtke , yep sorry I should have said 0.19.6. I got the same crash as a few months back. I.e. when trying to read a binary file from file storage |
@chj-damon thanks for this. maybe that was my issue as I had the below headers. Just to clarify you had to include ![]() |
@walterholohan I'm sorry that i made a mistake. it works fine |
@RonRadtke can you reopen please? |
I tried with above headers from @chj-damon but it still didn't work. Is it because my file I'm trying to upload as no filetype associated to it? |
Can you try to download a file the same way that has a file type assosciated? |
@RonRadtke do you think latest release will fix this issue? |
Our app crashes on RN 0.68.5 with react-native-blob-util v0.17.0
Our app is not written with new architecture so maybe it is the problem
When I downgrade to react-native-blob-util v0.16.4, it is working
The text was updated successfully, but these errors were encountered: